Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGTL] Allow multiple bulk element ids in identify #2252

Merged
merged 3 commits into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@endJunction
Copy link
Member

endJunction commented Oct 30, 2018

Upon request for Dirichlet BCs inside of the domain defined along lines.

@Thomas-TK Could you provide an example?

@Thomas-TK

This comment has been minimized.

Copy link
Member

Thomas-TK commented Oct 31, 2018

Of course, it's my pleasure !

@Thomas-TK

This comment has been minimized.

Copy link
Member

Thomas-TK commented Nov 1, 2018

Here we go: an unstructured triangle mesh and a Y-line going through the domain (typical for river BCs). Additionally, an according prism mesh.
Thank you
Thomas

SimpleRiverExample.zip

PS: that's how it looks like
riverpointallocation

@@ -133,21 +133,8 @@ std::vector<std::size_t> identifySubdomainMeshElements(
OGS_FATAL(
"Expect exactly one element to be found in the bulk mesh.");

This comment has been minimized.

@TomFischer

TomFischer Nov 2, 2018

Member

Is the error message still correct?

This comment has been minimized.

@endJunction

endJunction Nov 2, 2018

Author Member

Fixed: "exactly one" to at "least one".

@TomFischer
Copy link
Member

TomFischer left a comment

endJunction added some commits Oct 30, 2018

[MGTL] Allow multiple bulk element ids in identify
If the lower dimensional elements are inside the bulk mesh,
there is no unique bulk element associated with it, but
multiple elements.
In the case of unique elements, the behaviour didn't change.
In the case of multiple elements, the bulk element ids are
stored in the FieldData with accompanying CellData array
'number_bulk_elements'.
[T] Add "river" test for identifySubdoms tool.
Meshes kindly provided by Thomas_TK @ github <thomas.kalbacher@ufz.de>

@endJunction endJunction force-pushed the endJunction:AllowMultipleBulkElementsIdentification branch from 0aadff6 to ca943a7 Nov 2, 2018

@Thomas-TK

This comment has been minimized.

Copy link
Member

Thomas-TK commented Nov 2, 2018

Looks good with triangle mesh. . .will test it for prism meshes as well
riverpointallocationresult

@endJunction endJunction merged commit 4261f03 into ufz:master Nov 2, 2018

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:AllowMultipleBulkElementsIdentification branch Nov 2, 2018

@endJunction endJunction removed the WIP 🏗 label Nov 2, 2018

@Thomas-TK

This comment has been minimized.

Copy link
Member

Thomas-TK commented Nov 2, 2018

I works for the 3D prism model as well. !!!!

@Thomas-TK

This comment has been minimized.

Copy link
Member

Thomas-TK commented Nov 2, 2018

I tested triangles, line elements and individual points as elements on a triangle and prism mesh. Works very well as BCs inside the domain.
riverpointallocationresultprism

@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Nov 2, 2018

Put it in a ctest and add some docu on the benchmark page. Then, and only then, can you rely on these features being correct in the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.