Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialIDs #2270

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@endJunction
Copy link
Member

endJunction commented Nov 23, 2018

Follow up of #2264
Uniform access of materialIDs property. Some of the changes have long tails, especially in LiquidFlow.

Suggest to review commit-wise.

@endJunction endJunction force-pushed the endJunction:MaterialIds branch 2 times, most recently from 9e36145 to fc3b4ac Nov 23, 2018

@wenqing
Copy link
Member

wenqing left a comment

Looks good.

@TomFischer
Copy link
Member

TomFischer left a comment

Looks good 🍰 Feel free to merge my commits into yours.

endJunction added some commits Nov 23, 2018

[PL/MatL] Use MeL::materialIDs. Drop has_mat_ids.
The main change was in the creation of liquid flow process;
the succeeding changes are just adoptation to a pointer,
instead of a reference with boolean.

@endJunction endJunction force-pushed the endJunction:MaterialIds branch from 96b3988 to 5af96e1 Nov 27, 2018

@endJunction endJunction merged commit 13ac690 into ufz:master Nov 27, 2018

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:MaterialIds branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.