Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL] Infrastructure for setInitialConditions(). #2334

Merged
merged 2 commits into from Jan 31, 2019

Conversation

Projects
None yet
5 participants
@endJunction
Copy link
Member

endJunction commented Jan 29, 2019

Some processes might require setup of the initial conditions dependent variables in local assemblers.
The new interface allows such implementations.

See https://github.com/endJunction/ogs/tree/RMSaturation branch changes of RichardsFlow process for usage.

[PL] Infrastructure for setInitialConditions().
Some processes might require setup of the initial
conditions dependent variables in local assemblers.
The new interface allows such implementations.

@bilke bilke added the in progress label Jan 29, 2019

@ThieJan

This comment has been minimized.

Copy link
Contributor

ThieJan commented Jan 30, 2019

Thanks!
Could the interface be extended adding the current time (initial time) to the interface as well? This enables correct evaluation of parameters or other time dependent properties.

@bilke bilke removed the in progress label Jan 30, 2019

@TomFischer
Copy link
Member

TomFischer left a comment

Looks reasonable.

@TomFischer TomFischer merged commit b749811 into ufz:master Jan 31, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:SetInitialConditions branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.