Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL] support xyz-dependent parameters in Neumann bc #2339

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@norihiro-w
Copy link
Collaborator

norihiro-w commented Feb 1, 2019

as titled. The change is needed to use FunctionParameter to evaluate values for Neumann BC.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #2339 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2339      +/-   ##
=========================================
- Coverage   32.91%   32.9%   -0.02%     
=========================================
  Files         525     525              
  Lines       19712   19720       +8     
  Branches     4050    4050              
=========================================
  Hits         6489    6489              
- Misses       9980    9988       +8     
  Partials     3243    3243
Impacted Files Coverage Δ
NumLib/Fem/FiniteElement/TemplateIsoparametric.h 37.93% <0%> (-14.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0dc96...7515402. Read the comment docs.

@endJunction endJunction merged commit 6585152 into ufz:master Feb 1, 2019

4 of 5 checks passed

codecov/project 32.9% (-0.02%) compared to 7e0dc96
Details
codecov/patch Coverage not affected when comparing 7e0dc96...7515402
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

endJunction added a commit that referenced this pull request Feb 1, 2019

[PL] Don't reset position in setCoords.
Setting of the coordinates does not necessary invalidate the element id or integration point id.

Further rework is necessary for the whole class and is a fast fix for the changes in
#2339.

jbathmann added a commit to jbathmann/ogs that referenced this pull request Mar 5, 2019

[PL] Don't reset position in setCoords.
Setting of the coordinates does not necessary invalidate the element id or integration point id.

Further rework is necessary for the whole class and is a fast fix for the changes in
ufz#2339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.