Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Replace OGS_BUILD_TESTS with BUILD_TESTING #2350

Merged
merged 3 commits into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@bilke
Copy link
Member

bilke commented Feb 11, 2019

No description provided.

bilke added some commits Feb 11, 2019

[CMake] Replace OGS_BUILD_TESTS with BUILD_TESTING.
BUILD_TESTING is a CMake convention used widely.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2350 into master will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2350      +/-   ##
==========================================
+ Coverage   32.41%   32.89%   +0.47%     
==========================================
  Files         526      525       -1     
  Lines       20016    19720     -296     
  Branches     4050     4050              
==========================================
- Hits         6489     6487       -2     
+ Misses      10284     9989     -295     
- Partials     3243     3244       +1
Impacted Files Coverage Δ
GeoLib/Polyline.cpp 35.75% <0%> (-0.61%) ⬇️
...ousMedium/Permeability/createPermeabilityModel.cpp 0% <0%> (ø) ⬆️
Applications/ApplicationsLib/ProjectData.cpp 0% <0%> (ø) ⬆️
...Lib/PorousMedium/Permeability/DupuitPermeability.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4847caa...ac7308f. Read the comment docs.

@bilke bilke requested a review from endJunction Feb 11, 2019

@endJunction endJunction merged commit fcda44f into ufz:master Feb 11, 2019

5 checks passed

codecov/patch Coverage not affected when comparing 4847caa...ac7308f
Details
codecov/project 32.89% (+0.47%) compared to 4847caa
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190211.3 succeeded
Details

@bilke bilke deleted the bilke:cmake-testing branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.