Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing ogs-container-generator #2356

Merged
merged 10 commits into from Feb 13, 2019

Conversation

Projects
None yet
1 participant
@bilke
Copy link
Member

bilke commented Feb 13, 2019

There is a new project at ufz/ogs-container-generator where container image definitions can be created programmatically (based on NVIDIA/hpc-container-maker). This PR adds:

Other small changes:

  • Removed gcovr-script required for OGS_COVERAGE=ON. Install gcovr via pip now!
  • Added clean_coverage target which removes the coverage counters
  • Updated CSS library
  • Use newer CMake Python find module which favors Python 3 over 2 when both are available

@bilke bilke added the please review label Feb 13, 2019

@bilke bilke force-pushed the bilke:new-dockerfiles branch from 1ee47ca to d9f6c0a Feb 13, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #2356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2356   +/-   ##
=======================================
  Coverage   32.69%   32.69%           
=======================================
  Files         526      526           
  Lines       20269    20269           
  Branches     9358     9358           
=======================================
  Hits         6627     6627           
  Misses      10360    10360           
  Partials     3282     3282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2764107...d9f6c0a. Read the comment docs.

@bilke bilke removed the please review label Feb 13, 2019

@bilke bilke merged commit 638dd70 into ufz:master Feb 13, 2019

2 of 3 checks passed

ufz.ogs in progress
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@bilke bilke deleted the bilke:new-dockerfiles branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.