Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation point output #2372

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
1 participant
@endJunction
Copy link
Member

endJunction commented Feb 19, 2019

Just an example of a subdomain output and also just checking the combination of geometry input and multiple meshes output.

endJunction added some commits Feb 19, 2019

[T] RM; Add observation point output.
Using geometry input but multiple meshes output feature.
[T] RM; Add observation point reference files.
Generation of the pvd files is not (yet) implemented,
but easily possible with an one-liner:

sed 's/RichardsFlow_2d_small/Richards_2d_geometry_OBSERVATION_POINT/g' RichardsFlow_2d_small_pcs_0.pvd> Richards_2d_geometry_OBSERVATION_POINT_pcs_0.pvd
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #2372 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
+ Coverage   32.53%   32.66%   +0.12%     
==========================================
  Files         527      527              
  Lines       20188    19766     -422     
  Branches     9624     9258     -366     
==========================================
- Hits         6568     6456     -112     
+ Misses      10279    10022     -257     
+ Partials     3341     3288      -53
Impacted Files Coverage Δ
GeoLib/AnalyticalGeometry.cpp 35.81% <0%> (-8.24%) ⬇️
GeoLib/SurfaceGrid.cpp 53.7% <0%> (-2.78%) ⬇️
Applications/ApplicationsLib/ProjectData.cpp 0% <0%> (ø) ⬆️
GeoLib/GEOObjects.cpp 30.9% <0%> (+3.58%) ⬆️
GeoLib/GEOObjects.h 35.89% <0%> (+10.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e4d1b...069455e. Read the comment docs.

@endJunction endJunction merged commit 4cc99b1 into ufz:master Feb 20, 2019

5 checks passed

codecov/patch Coverage not affected when comparing 52e4d1b...069455e
Details
codecov/project 32.66% (+0.12%) compared to 52e4d1b
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190219.13 succeeded
Details

@endJunction endJunction deleted the endJunction:ObservationPointOutput branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.