Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExtractSurface] Enable switch for binary or ascii output. #2401

Merged
merged 3 commits into from Mar 6, 2019

Conversation

Projects
None yet
3 participants
@TomFischer
Copy link
Member

TomFischer commented Mar 5, 2019

No description provided.

@rinkk

This comment has been minimized.

Copy link
Member

rinkk commented Mar 5, 2019

Keep in mind that writeMeshToFile() handles both *.msh and *.vtu files. A vtk-based compression parameter makes no sense here.

Instead, I would keep writeMeshToFile() as it is, remove the call in the utility and replace it with

MeshLib::IO::VtuInterface vtkIO(&_mesh, mode, compression);
vtkIO.writeToFile(file_name.toStdString().c_str());

where compression is either "true" or "false" and mode is either "vtkXMLWriter::Appended" or "vtkXMLWriter::Ascii", respectively.

@TomFischer TomFischer force-pushed the TomFischer:EnableBinaryOrASCIIOutput branch from a7bf410 to 0eca143 Mar 6, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #2401 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2401   +/-   ##
=======================================
  Coverage   32.98%   32.98%           
=======================================
  Files         529      529           
  Lines       19793    19793           
  Branches     9295     9295           
=======================================
  Hits         6528     6528           
  Misses       9940     9940           
  Partials     3325     3325

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1cccd...d417925. Read the comment docs.

@TomFischer TomFischer force-pushed the TomFischer:EnableBinaryOrASCIIOutput branch from 0eca143 to d417925 Mar 6, 2019

@TomFischer

This comment has been minimized.

Copy link
Member Author

TomFischer commented Mar 6, 2019

@rinkk

A vtk-based compression parameter makes no sense here.

Reverted this change.

@endJunction
Copy link
Member

endJunction left a comment

@rinkk If you agree with the changes, the PR can be merged.

@rinkk

This comment has been minimized.

Copy link
Member

rinkk commented Mar 6, 2019

👍

@endJunction endJunction merged commit 7ea32e5 into ufz:master Mar 6, 2019

3 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190306.7 succeeded
Details

@endJunction endJunction deleted the TomFischer:EnableBinaryOrASCIIOutput branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.