Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurfaceFlux calculates now specific flux #2411

Merged
merged 14 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@TomFischer
Copy link
Member

TomFischer commented Mar 8, 2019

No description provided.

@endJunction
Copy link
Member

endJunction left a comment

Didn't look in the ctests, though.

@TomFischer TomFischer force-pushed the TomFischer:FixBalanceIssue branch from cbae003 to c0376f1 Mar 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #2411 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2411      +/-   ##
==========================================
+ Coverage   32.59%   32.72%   +0.12%     
==========================================
  Files         530      530              
  Lines       20037    19850     -187     
  Branches     9503     9325     -178     
==========================================
- Hits         6532     6496      -36     
+ Misses      10167    10000     -167     
- Partials     3338     3354      +16
Impacted Files Coverage Δ
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
MeshLib/CoordinateSystem.cpp 42.85% <0%> (-14.29%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 72.95% <0%> (-4.1%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-3.04%) ⬇️
GeoLib/SurfaceGrid.cpp 53.7% <0%> (-2.78%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 76.74% <0%> (-2.33%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 41.17% <0%> (-1.97%) ⬇️
GeoLib/Polyline.cpp 35.31% <0%> (-1.88%) ⬇️
MeshLib/MeshSurfaceExtraction.cpp 30.81% <0%> (-1.26%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64de79a...a7fbd39. Read the comment docs.

@TomFischer TomFischer force-pushed the TomFischer:FixBalanceIssue branch from c0376f1 to acdde44 Mar 11, 2019

TomFischer added some commits Mar 7, 2019

[T/ComponentTransport] Rename data_array in test.
Rename to better reflect the information stored in the data_array.
[T/GWF] Rename update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/GWF] Rename update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/GWF] Rename update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/GWF] Rename update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/GWF] Rename update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/GWF] Rename update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/HT] Rename and update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/HT] Rename and update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
[T/HC] Rename and update expected solution.
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.

@TomFischer TomFischer force-pushed the TomFischer:FixBalanceIssue branch from acdde44 to a7fbd39 Mar 11, 2019

@endJunction endJunction merged commit be937ec into ufz:master Mar 11, 2019

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing 64de79a...a7fbd39
Details
codecov/project 32.72% (+0.12%) compared to 64de79a
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190311.5 succeeded
Details

@TomFischer TomFischer deleted the TomFischer:FixBalanceIssue branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.