Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QVtkOpenGLWidget #2432

Merged
merged 6 commits into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@endJunction
Copy link
Member

endJunction commented Mar 19, 2019

The QVTKWidget is deprecated in VTK-8.1.

Fixes #2354

@endJunction endJunction requested a review from rinkk Mar 19, 2019

@bilke

This comment has been minimized.

Copy link
Member

bilke commented Mar 19, 2019

@endJunction endJunction force-pushed the endJunction:UseQVtkOpenGlWidget branch from 6abc68e to e539de2 Mar 19, 2019

@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Mar 19, 2019

@bilke That's strange indeed. I carefully tested the original small change again, and, yes, they are producing a working DE. So is the newest set of the changes.
It means, we definitely need another test on a windows machine.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #2432 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2432      +/-   ##
==========================================
- Coverage   32.76%   32.65%   -0.12%     
==========================================
  Files         549      549              
  Lines       20297    20297              
  Branches     9532     9576      +44     
==========================================
- Hits         6650     6627      -23     
+ Misses      10204    10194      -10     
- Partials     3443     3476      +33
Impacted Files Coverage Δ
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
MeshLib/CoordinateSystem.cpp 42.85% <0%> (-14.29%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 72.95% <0%> (-4.1%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-3.04%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 76.74% <0%> (-2.33%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 41.17% <0%> (-1.97%) ⬇️
MeshLib/MeshSurfaceExtraction.cpp 30.81% <0%> (-1.26%) ⬇️
GeoLib/Polyline.cpp 35.31% <0%> (-1.25%) ⬇️
NumLib/DOF/LocalToGlobalIndexMap.cpp 48.67% <0%> (-1.06%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc667a...e539de2. Read the comment docs.

@bilke

This comment has been minimized.

Copy link
Member

bilke commented Mar 19, 2019

@endJunction I tested on Windows:

  • your changes are not enough: segfault
  • with my additions: fine 👍

@endJunction endJunction merged commit 98cc67c into ufz:master Mar 19, 2019

5 of 6 checks passed

codecov/project 32.65% (-0.12%) compared to 5fc667a
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing 5fc667a...e539de2
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190319.17 succeeded
Details

@endJunction endJunction deleted the endJunction:UseQVtkOpenGlWidget branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.