Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THM #2446

Merged
merged 4 commits into from Apr 1, 2019

Conversation

@endJunction
Copy link
Member

commented Mar 31, 2019

Code and tests part of the #2269 pull-request w/o documentation, which needs serious mistake fixes.

The code is reviewed in the linked "original" PR, and just split into several meaningful commits.
Just for testing in the CI.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?

@endJunction endJunction force-pushed the endJunction:THM branch from e139608 to 88d6e7f Mar 31, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 31, 2019

Codecov Report

Merging #2446 into master will decrease coverage by 0.38%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
- Coverage   33.04%   32.66%   -0.39%     
==========================================
  Files         552      549       -3     
  Lines       20886    20312     -574     
  Branches    10055     9585     -470     
==========================================
- Hits         6902     6635     -267     
- Misses      10181    10208      +27     
+ Partials     3803     3469     -334
Impacted Files Coverage Δ
Applications/ApplicationsLib/ProjectData.cpp 0% <0%> (ø) ⬆️
Applications/FileIO/GocadIO/Region.h 0% <0%> (-100%) ⬇️
Applications/FileIO/GocadIO/Layer.h 0% <0%> (-100%) ⬇️
Applications/FileIO/GocadIO/CoordinateSystem.h 0% <0%> (-100%) ⬇️
Applications/FileIO/GocadIO/IndexCalculator.h 0% <0%> (-70%) ⬇️
Applications/FileIO/GocadIO/Layer.cpp 0% <0%> (-42.11%) ⬇️
BaseLib/FileTools.h 0% <0%> (-38.47%) ⬇️
Applications/FileIO/GocadIO/Region.cpp 0% <0%> (-35.72%) ⬇️
Applications/FileIO/GocadIO/GocadNode.h 0% <0%> (-33.34%) ⬇️
Applications/FileIO/GocadIO/Property.h 0% <0%> (-33.34%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7de6a...88d6e7f. Read the comment docs.

@TomFischer TomFischer merged commit fe445f2 into ufz:master Apr 1, 2019

4 of 6 checks passed

codecov/patch 0% of diff hit (target 33.04%)
Details
codecov/project 32.66% (-0.39%) compared to 4c7de6a
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190331.2 succeeded
Details

@TomFischer TomFischer deleted the endJunction:THM branch Apr 1, 2019

@endJunction endJunction referenced this pull request Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.