Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] Added support for world files to georeference raster files #2460

Merged
merged 3 commits into from Apr 10, 2019

Conversation

@rinkk
Copy link
Member

commented Apr 9, 2019

Image reader tries to find a world file when a raster is loaded to georeference the data correctly.

If libgeotiff is not found, vtkTIFFReader is now used instead of just giving an error msg. (vtkTiffReader is not great and has issues with lots of TIFF-variants so it's really just a fallback in case there is no alternative available.)

  1. Feature description was added to the changelog

@rinkk rinkk force-pushed the rinkk:worldfiles branch from 085f15b to 4ff790f Apr 9, 2019

@TomFischer
Copy link
Member

left a comment

Looks good.

@bilke

bilke approved these changes Apr 10, 2019

Copy link
Member

left a comment

👍 Although a test would be nice.

@rinkk rinkk force-pushed the rinkk:worldfiles branch from be6176a to c02e2c8 Apr 10, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 10, 2019

Codecov Report

Merging #2460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2460   +/-   ##
======================================
  Coverage    32.8%   32.8%           
======================================
  Files         549     549           
  Lines       20329   20329           
  Branches     9596    9596           
======================================
  Hits         6668    6668           
  Misses      10216   10216           
  Partials     3445    3445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5297d51...39b1f6c. Read the comment docs.

".bpw", ".bmpw", ".bpwx",
".wld" };

for (std::string ext : supported_extensions)

This comment has been minimized.

Copy link
@endJunction

endJunction Apr 10, 2019

Member
Suggested change
for (std::string ext : supported_extensions)
for (std::string const& ext : supported_extensions)

@endJunction endJunction force-pushed the rinkk:worldfiles branch from c02e2c8 to 39b1f6c Apr 10, 2019

@endJunction endJunction merged commit 818bb91 into ufz:master Apr 10, 2019

2 of 4 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190410.6 succeeded
Details

@rinkk rinkk deleted the rinkk:worldfiles branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.