Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vtkdiff; Mesh comparison option. #2485

Merged
merged 3 commits into from May 9, 2019

Conversation

@endJunction
Copy link
Member

commented May 3, 2019

testing the corresponding submodule PR (ufz/vtkdiff#11).

  • Actual test of two meshes.
  • Changelog.

@endJunction endJunction force-pushed the endJunction:vtkdiff branch from 06a43ec to 2c33d0b May 6, 2019

@codecov

This comment has been minimized.

Copy link

commented May 6, 2019

Codecov Report

Merging #2485 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2485      +/-   ##
==========================================
- Coverage   32.84%   32.71%   -0.13%     
==========================================
  Files         554      554              
  Lines       20505    20505              
  Branches     9658     9702      +44     
==========================================
- Hits         6735     6709      -26     
+ Misses      10280    10271       -9     
- Partials     3490     3525      +35
Impacted Files Coverage Δ
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
MeshLib/CoordinateSystem.cpp 42.85% <0%> (-14.29%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 72.95% <0%> (-4.1%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-3.04%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 76.74% <0%> (-2.33%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 41.17% <0%> (-1.97%) ⬇️
GeoLib/Polyline.cpp 35.31% <0%> (-1.88%) ⬇️
MeshLib/MeshSurfaceExtraction.cpp 30.81% <0%> (-1.26%) ⬇️
NumLib/DOF/LocalToGlobalIndexMap.cpp 48.67% <0%> (-1.06%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982e5d7...ea04f31. Read the comment docs.

@endJunction endJunction force-pushed the endJunction:vtkdiff branch from 2c33d0b to ea04f31 May 7, 2019

@endJunction endJunction requested a review from bilke May 7, 2019

@endJunction

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@bilke It might turn out, that you want me to refactor the cmake scripts a little. There are few lines shared between the AddTest, OgsTest, and MeshTest.

@endJunction endJunction removed the don't merge label May 8, 2019

@bilke

bilke approved these changes May 9, 2019

@bilke bilke merged commit 2606f0f into ufz:master May 9, 2019

3 of 4 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190507.1 succeeded
Details

@bilke bilke deleted the endJunction:vtkdiff branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.