Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HT] Use MPL for solid phase properties. #2487

Merged
merged 3 commits into from May 13, 2019

Conversation

@TomFischer
Copy link
Member

commented May 9, 2019

Using MPL for solid phase properties needs also changes in the project files. For the benchmarks this is done in this PR.

  1. Feature description was added to the changelog
  2. All HT-Tests were changed, except the decovalex test since these tests use mesh parameters that are not implemented yet in the MPL. As soon as we can use a parameter as MPL::Property we can reenable the tests.

@bilke bilke self-requested a review May 9, 2019

@endJunction

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@bilke Merge, when ready.
@TomFischer Just a rebase.

@endJunction endJunction force-pushed the TomFischer:HT-UseMPLForSolidPhase branch from 6d4844f to a6e42ad May 10, 2019

@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@a1b9f4d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2487   +/-   ##
=========================================
  Coverage          ?   32.88%           
=========================================
  Files             ?      554           
  Lines             ?    20505           
  Branches          ?     9702           
=========================================
  Hits              ?     6744           
  Misses            ?    10268           
  Partials          ?     3493

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b9f4d...19eaf15. Read the comment docs.

@TomFischer TomFischer force-pushed the TomFischer:HT-UseMPLForSolidPhase branch from a6e42ad to 9a34d02 May 13, 2019

@TomFischer TomFischer force-pushed the TomFischer:HT-UseMPLForSolidPhase branch from 9a34d02 to 19eaf15 May 13, 2019

@TomFischer TomFischer merged commit 13858dd into ufz:master May 13, 2019

3 of 4 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190513.3 succeeded
Details

@TomFischer TomFischer deleted the TomFischer:HT-UseMPLForSolidPhase branch May 13, 2019

bilke added a commit to bilke/ogs that referenced this pull request May 15, 2019

bilke added a commit to bilke/ogs that referenced this pull request May 15, 2019

bilke added a commit to HBShaoUFZ/ogs that referenced this pull request May 16, 2019

bilke added a commit to bilke/ogs that referenced this pull request May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.