Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive transport feature with Phreeqc interface #2494

Merged
merged 38 commits into from Jun 6, 2019

Conversation

@HBShaoUFZ
Copy link
Contributor

commented May 14, 2019

This PR introduces the reactive transport feature with the help of a Phreeqc interface.

In the project input file, several keywords have been added to define the chemical reaction system. These keywords include "SOLUTION", "EQUILIBRIUM_PHASE", "KINETICS" and "RATES“.

Two benchmark tests have been added along with this PR. One case designed for equilibrium reactions and the other for kinetic processes.

_mesh_vec[0]->getNumberOfBaseNodes(), config);
}
else
OGS_FATAL(

This comment has been minimized.

Copy link
@endJunction

endJunction May 14, 2019

Member

be consistent with braces, if an if is braced, then the else also should be. Use clang-tidy's readability-braces-around-statements check for automatic fix.

This comment has been minimized.

Copy link
@HBShaoUFZ

HBShaoUFZ May 15, 2019

Author Contributor

fixed

@HBShaoUFZ HBShaoUFZ force-pushed the HBShaoUFZ:PhreeqcInterface branch from 92dce59 to 3656ffc May 15, 2019

@bilke bilke force-pushed the HBShaoUFZ:PhreeqcInterface branch 2 times, most recently from 8d12366 to d8fa2dc May 16, 2019

renchao-lu and others added some commits Jun 4, 2019

@HBShaoUFZ HBShaoUFZ force-pushed the HBShaoUFZ:PhreeqcInterface branch from 2869b95 to b7796b6 Jun 6, 2019

@endJunction endJunction merged commit c021424 into ufz:master Jun 6, 2019

3 of 5 checks passed

codecov/patch 0% of diff hit (target 32.89%)
Details
codecov/project 32.14% (-0.76%) compared to dd11e53
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190606.7 succeeded
Details

@endJunction endJunction removed the WIP 🏗 label Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.