Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HM velocity fix gravity sign #2507

Merged
merged 3 commits into from May 23, 2019

Conversation

@FZill
Copy link
Contributor

commented May 22, 2019

add HM gravity flow test and fix gravity sign

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. docu added
@TomFischer
Copy link
Member

left a comment

👍

@FZill FZill force-pushed the FZill:HM_Flow_Gravity_Check branch from d5fa4aa to bdd696e May 23, 2019

@codecov

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #2507 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2507      +/-   ##
=========================================
- Coverage   32.92%   32.8%   -0.12%     
=========================================
  Files         555     555              
  Lines       20767   20747      -20     
  Branches     9785    9772      -13     
=========================================
- Hits         6838    6807      -31     
+ Misses      10443   10429      -14     
- Partials     3486    3511      +25
Impacted Files Coverage Δ
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 72.95% <0%> (-3.28%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 69.04% <0%> (-2.39%) ⬇️
GeoLib/Surface.cpp 56.81% <0%> (-2.28%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 43.92% <0%> (-1.87%) ⬇️
GeoLib/Polyline.cpp 36.13% <0%> (-1.87%) ⬇️
NumLib/DOF/LocalToGlobalIndexMap.cpp 47.54% <0%> (-1.64%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-1.52%) ⬇️
MeshLib/MeshSurfaceExtraction.cpp 30.2% <0%> (-1.05%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b8a9a...c7cc159. Read the comment docs.

@FZill FZill force-pushed the FZill:HM_Flow_Gravity_Check branch from 86c31a4 to 773d8cb May 23, 2019

@endJunction endJunction force-pushed the FZill:HM_Flow_Gravity_Check branch from 773d8cb to c7cc159 May 23, 2019

@endJunction endJunction merged commit b0d1463 into ufz:master May 23, 2019

4 of 6 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
codecov/project 32.8% (-0.12%) compared to 47b8a9a
Details
codecov/patch Coverage not affected when comparing 47b8a9a...c7cc159
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190523.5 succeeded
Details

endJunction added a commit that referenced this pull request May 27, 2019

@FZill FZill deleted the FZill:HM_Flow_Gravity_Check branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.