Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to linear mesh tests #2519

Merged
merged 3 commits into from Jun 20, 2019

Conversation

@endJunction
Copy link
Member

commented Jun 7, 2019

Current conversion routine relies on the numbering of the nodes, but this is not necessary.
A test and a proposed change are included.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented? (no new features)

@endJunction endJunction force-pushed the endJunction:ConvertToLinearMeshTests branch from f91108c to f169043 Jun 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #2519 into master will decrease coverage by 0.03%.
The diff coverage is 19.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
- Coverage    32.2%   32.16%   -0.04%     
==========================================
  Files         573      573              
  Lines       21219    21229      +10     
  Branches     9925     9977      +52     
==========================================
- Hits         6834     6829       -5     
+ Misses      10901    10872      -29     
- Partials     3484     3528      +44
Impacted Files Coverage Δ
MeshLib/MeshEditing/ConvertToLinearMesh.cpp 21.56% <19.04%> (+21.56%) ⬆️
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 72.95% <0%> (-3.28%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 69.04% <0%> (-2.39%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 43.92% <0%> (-1.87%) ⬇️
NumLib/DOF/LocalToGlobalIndexMap.cpp 47.54% <0%> (-1.64%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-1.52%) ⬇️
GeoLib/Polyline.cpp 36.13% <0%> (-1.25%) ⬇️
MeshLib/MeshSurfaceExtraction.cpp 30.2% <0%> (-1.05%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa81aa...30f5385. Read the comment docs.

@endJunction endJunction force-pushed the endJunction:ConvertToLinearMeshTests branch 4 times, most recently from 0c7a588 to 30f5385 Jun 12, 2019

@endJunction

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

Merging tonight...

endJunction added some commits May 29, 2019

[MeL] Generalize to-linear-mesh conversion.
Previously the conversion relied on the node numbering,
which is not necessary.

@endJunction endJunction force-pushed the endJunction:ConvertToLinearMeshTests branch from 30f5385 to be317d4 Jun 20, 2019

@endJunction endJunction merged commit 129e7e3 into ufz:master Jun 20, 2019

3 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190620.1 succeeded
Details

@endJunction endJunction deleted the endJunction:ConvertToLinearMeshTests branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.