Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIE/HM fracture permeability models; CubicLaw #2542

Merged

Conversation

@endJunction
Copy link
Member

commented Jun 26, 2019

Based on #2541.

Generalizes the permeability computation in the fracture. Adding infrastructure and the currently only used cubic law.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added? Project files updated, no changes to references.
  3. Any new feature or behavior change was documented?

@endJunction endJunction force-pushed the endJunction:LIEFracturePermeabilityModelsCubicLaw branch 3 times, most recently from 56ec3b5 to dbb4e87 Jun 27, 2019

@wenqing

wenqing approved these changes Jul 1, 2019

Copy link
Member

left a comment

Only two comments.

{
std::unique_ptr<Permeability> createCubicLaw(BaseLib::ConfigTree const& config)
{
//! \ogs_file_param{prj__processes__process__HYDRO_MECHANICS_WITH_LIE__fracture_properties__permeability_model__type}

This comment has been minimized.

Copy link
@wenqing

wenqing Jul 1, 2019

Member

The model is more general. It is better to change the path to
//! \ogs_file_param_special{material__porous_medium__fracture_properties__permeability_model__type}.

@@ -282,6 +283,24 @@ std::unique_ptr<Process> createHydroMechanicsProcess(
"time-dependent.",
frac_prop->aperture0.name.c_str());
}

auto permeability_model_config =

This comment has been minimized.

Copy link
@wenqing

wenqing Jul 1, 2019

Member

This part can be put into a creator function, e.g
createFracturePermeability(...)
Then the path to the doc can be changed as that in my previous comment.

@wenqing

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Docker inspect error, which is unrelated to this PR.

@wenqing wenqing referenced this pull request Jul 1, 2019
2 of 3 tasks complete

@endJunction endJunction added the WIP 🏗 label Jul 1, 2019

@endJunction endJunction force-pushed the endJunction:LIEFracturePermeabilityModelsCubicLaw branch 2 times, most recently from 6108371 to 7180dfc Jul 4, 2019

endJunction added some commits Dec 5, 2017

[MatL] Fracture permeability models. CubicLaw.
This adds infrastructure for other permeability models, but for now only
the existing/implemented cubic law is put.
[PL] LIE/HM: Extend FractureProperty for HM.
Adding permeability model to the derived class.
[MatL] PM/Permeability; Fix doxygen warning.
Remove specific file name in \file macro to avoid matching
it against other/new Permeability.h.

@endJunction endJunction force-pushed the endJunction:LIEFracturePermeabilityModelsCubicLaw branch from 7180dfc to 57f312f Jul 4, 2019

@endJunction endJunction merged commit a489890 into ufz:master Jul 4, 2019

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190704.8 succeeded
Details

@endJunction endJunction deleted the endJunction:LIEFracturePermeabilityModelsCubicLaw branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.