Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIE/HM fracture permeability model: ConstantPermeability #2543

Conversation

@endJunction
Copy link
Member

commented Jun 27, 2019

A constant permeability model for fractures.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?

Documentation (doxygen) build will probably fail. I'm looking for solutions. The code and tests should be OK.

@endJunction endJunction changed the title Lie fracture permeability models constant permeability LIE/HM fracture permeability model: ConstantPermeability Jun 27, 2019

@endJunction endJunction force-pushed the endJunction:LIEFracturePermeabilityModelsConstantPermeability branch 2 times, most recently from e863baf to 284a259 Jun 27, 2019

@wenqing

wenqing approved these changes Jul 1, 2019

double const /*aperture0*/,
double const /*aperture_m*/) const
{
return 0;

This comment has been minimized.

Copy link
@wenqing
"non-negative.",
DBUG(
"Element %d, gp %d: Fracture aperture is %g, but it is "
"expected to be non-negative.",
_element.getID(), ip, b_m);
}

This comment has been minimized.

Copy link
@wenqing

wenqing Jul 1, 2019

Member

b_m = 0.0;

@endJunction endJunction force-pushed the endJunction:LIEFracturePermeabilityModelsConstantPermeability branch from 284a259 to 85963f4 Jul 1, 2019

@endJunction endJunction removed the WIP 🏗 label Jul 1, 2019

std::unique_ptr<Permeability> createConstantPermeability(
BaseLib::ConfigTree const& config)
{
//! \ogs_file_param{prj__processes__process__HYDRO_MECHANICS_WITH_LIE__fracture_properties__permeability_model__type}

This comment has been minimized.

Copy link
@wenqing

wenqing Jul 1, 2019

Member

As my comment to #2542, it is better to change the path of doc as
//! \ogs_file_param_special{material__porous_medium__fracture_properties__permeability_model__type}.

@@ -282,6 +284,30 @@ std::unique_ptr<Process> createHydroMechanicsProcess(
"time-dependent.",
frac_prop->aperture0.name.c_str());
}

auto permeability_model_config =

This comment has been minimized.

Copy link
@wenqing

wenqing Jul 1, 2019

Member

As that in my comments in #2542, a creator function is better for this part because this part is for the material property and it can be process independent.

This comment has been minimized.

Copy link
@wenqing

wenqing Jul 1, 2019

Member

The function can be put in MaterialLib/FractureModels/

@endJunction endJunction added the WIP 🏗 label Jul 1, 2019

@endJunction endJunction force-pushed the endJunction:LIEFracturePermeabilityModelsConstantPermeability branch from 85963f4 to bfda49c Jul 5, 2019

@endJunction endJunction removed the WIP 🏗 label Jul 5, 2019

@wenqing

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

@endJunction endJunction merged commit 5267932 into ufz:master Jul 5, 2019

3 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190705.6 succeeded
Details

@endJunction endJunction deleted the endJunction:LIEFracturePermeabilityModelsConstantPermeability branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.