Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydroMechanics non-equilibrium initial states. #2561

Open
wants to merge 6 commits into
base: master
from

Conversation

@endJunction
Copy link
Member

commented Jul 9, 2019

Adding same non-equilibrium initial states as for the SmallDeformation process ##2501.

Meanwhile the theoretical ideas were developed further and this is only for the comparison with the next new implementation and also provides the project files/tests. The new idea is to include the non-equilibrium in the residuum.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?

@endJunction endJunction force-pushed the endJunction:HMNEIC branch 4 times, most recently from 6c03415 to 2a11774 Jul 10, 2019

@@ -0,0 +1,3 @@
Non-equilibrium initial state variables which are not explicitly in equilibrium

This comment has been minimized.

Copy link
@wenqing

wenqing Jul 17, 2019

Member

not explicitly --> implicitly.

@wenqing

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Will the changes in the local assembler be in another PR?

@endJunction

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

Yes, the F^{oob} (out of balance forces) formulation will follow in other PR.

@endJunction endJunction force-pushed the endJunction:HMNEIC branch from 2a11774 to 2b8a083 Aug 5, 2019

@endJunction endJunction added please review and removed WIP 🏗 labels Aug 6, 2019

@endJunction endJunction force-pushed the endJunction:HMNEIC branch from 2b8a083 to e5be404 Aug 6, 2019

@@ -188,13 +188,45 @@ std::unique_ptr<Process> createHydroMechanicsProcess(
config.getConfigParameter<double>(
"reference_temperature", std::numeric_limits<double>::quiet_NaN());

// Non-equilibrium variables
ParameterLib::Parameter<double> const* nonequilibrium_stress = nullptr;

This comment has been minimized.

Copy link
@TomFischer

TomFischer Aug 17, 2019

Member

Just out of curiosity: Why not ´unique_ptr`?

This comment has been minimized.

Copy link
@endJunction

endJunction Aug 18, 2019

Author Member

It's a non-owning optional parameter.

@@ -97,6 +101,12 @@ struct HydroMechanicsProcessData
ParameterLib::Parameter<double> const& porosity;
/// Solid's density. A scalar quantity, ParameterLib::Parameter<double>.
ParameterLib::Parameter<double> const& solid_density;

/// Optional, non-equilibrium stress parameter.
ParameterLib::Parameter<double> const* const nonequilibrium_stress;

This comment has been minimized.

Copy link
@TomFischer

TomFischer Aug 17, 2019

Member

Why not ´unique_ptr´?

<Collection>
<DataSet timestep="0" group="" part="0" file="into_initial_state_pcs_0_ts_0_t_0.000000.vtu"/>
</Collection>
</VTKFile>

This comment has been minimized.

Copy link
@TomFischer

TomFischer Aug 17, 2019

Member

Is the pvd file needed?

@TomFischer

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

Are the gml files needed? I didn´t see references in the prooject files.

@TomFischer
Copy link
Member

left a comment

The PR looks in general good. Some small things to discuss. After resolving the conflicts and when tests are green:

@wenqing

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

I guess that Tests/Data/HydroMechanics/InitialStates/pressure/Docu_HM_Non_Equilibrium_Initial_States.pdf is for the documentation of one benchmark. However the web content file, which should refer to that PDF is missing.

@wenqing
Copy link
Member

left a comment

Looks good except a documentation of one benchmark is missing.

@@ -269,11 +302,11 @@ void HydroMechanicsLocalAssembler<ShapeFunctionDisplacement,

// pressure equation
local_rhs.template segment<pressure_size>(pressure_index).noalias() -=
laplace_p * p + storage_p * p_dot + Kpu * u_dot;
laplace_p * (p - p_neq) + storage_p * p_dot + Kpu * u_dot;

This comment has been minimized.

Copy link
@wenqing

wenqing Aug 19, 2019

Member

I think that every simulation starts from the previous status, whether which is equilibrium (may from the previous simulation) or non-equilibrium (specfied). Therefore p_neq should be p0, and local_rhs should not be changed. This is a suggestion for future change. The PR itself is OK with the current consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.