Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL] Output Solutions of Immobile Phases #2564

Merged
merged 8 commits into from Jul 16, 2019

Conversation

@renchao-lu
Copy link
Member

commented Jul 10, 2019

As titled. The solutions of immobile phases defined in the chemical system, i.e., equilibrium phases and kinetic reactants, will be automatically written into the result files. Defining additional transport processes for outputting the solutions of immobile phases is not needed any more.

@renchao-lu renchao-lu force-pushed the renchao-lu:OutputImmobilePhases branch from e6f8ffa to 4182022 Jul 13, 2019

@renchao-lu

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2019

The changes for outputting amounts of immobile phases (equilibrium phases and kinetic reactants) are constrained within the ChemistryLib. As you expected, there is definitely no need of intruding the ProcessLib::Output. In this way, least changes are necessary. Thanks for the guidance. @endJunction

@endJunction
Copy link
Member

left a comment

Looks better!
Smaller things to fix...

@renchao-lu renchao-lu force-pushed the renchao-lu:OutputImmobilePhases branch from 4182022 to becf0cf Jul 15, 2019

@@ -11,6 +11,7 @@

#include <memory>

#include "MeshLib/Mesh.h"

This comment has been minimized.

Copy link
@endJunction

endJunction Jul 15, 2019

Member

fwd decl should work here too.

This comment has been minimized.

Copy link
@renchao-lu

renchao-lu Jul 15, 2019

Author Member

Good catch. Fixed.

@renchao-lu renchao-lu force-pushed the renchao-lu:OutputImmobilePhases branch from becf0cf to f6acb1a Jul 15, 2019

@endJunction endJunction merged commit f2b0e69 into ufz:master Jul 16, 2019

3 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190715.13 succeeded
Details

@renchao-lu renchao-lu deleted the renchao-lu:OutputImmobilePhases branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.