Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time dependent heterogeneous parameter implementation #2588

Merged

Conversation

@TomFischer
Copy link
Member

commented Aug 2, 2019

Time dependent heterogeneous parameter implementation that can be used for instance for time dependent heterogeneous boundary conditions and source terms.

  1. Feature description is added to the changelog
  2. Tests covering your feature are added
  3. New feature is documented

@TomFischer TomFischer force-pushed the TomFischer:TimeDependentHeterogeneousParameter branch from 96caf32 to 7c535cd Aug 2, 2019

if (type == "TimeDependentHeterogeneousParameter")
{
INFO("TimeDependentHeterogeneousParameter: %s", name.c_str());
auto param =

This comment has been minimized.

Copy link
@endJunction

endJunction Aug 2, 2019

Member
Suggested change
auto param =
return

This comment has been minimized.

Copy link
@TomFischer

TomFischer Aug 5, 2019

Author Member

Changed.

std::string name,
std::vector<PairTimeParameterName>
time_parameter_name_mapping)
: Parameter<double>(name, nullptr),

This comment has been minimized.

Copy link
@endJunction

endJunction Aug 2, 2019

Member
Suggested change
: Parameter<double>(name, nullptr),
: Parameter<double>(std::move(name), nullptr),

This comment has been minimized.

Copy link
@TomFischer

TomFischer Aug 5, 2019

Author Member

Added.

std::vector<PairTimeParameterName>
time_parameter_name_mapping);

~TimeDependentHeterogeneousParameter() override = default;

This comment has been minimized.

Copy link
@endJunction

endJunction Aug 2, 2019

Member
Suggested change
~TimeDependentHeterogeneousParameter() override = default;

This comment has been minimized.

Copy link
@TomFischer

TomFischer Aug 5, 2019

Author Member

Removed.

@TomFischer TomFischer force-pushed the TomFischer:TimeDependentHeterogeneousParameter branch 3 times, most recently from b9ea0d1 to 65961a1 Aug 5, 2019

@endJunction

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

The .mp4 file must be 'lfs'ed. ✔️

@TomFischer TomFischer force-pushed the TomFischer:TimeDependentHeterogeneousParameter branch from 65961a1 to 944b9f9 Aug 6, 2019

@TomFischer TomFischer force-pushed the TomFischer:TimeDependentHeterogeneousParameter branch from 944b9f9 to cc88a54 Aug 6, 2019

@wenqing

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Just curious: can it be possible to realize the same functionality by BC/ST * f(t), where f(t) is a time factor function.

@TomFischer

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Just curious: can it be possible to realize the same functionality by BC/ST * f(t), where f(t) is a time factor function.

Do you mean something like CurveScaledParameter? I think Erik was using CurveScaledParameters before, but it was very cumbersome since he needed many of them to reproduce the spatial heterogeneity. The implementation in this PR needs only one (possible spatial heterogeneous) parameter for each time step.

@wenqing

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@TomFischer I see.

@wenqing

wenqing approved these changes Aug 6, 2019

Copy link
Member

left a comment

Looks fine.

@endJunction endJunction merged commit 9bbdb09 into ufz:master Aug 6, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
deploy/netlify Deploy preview ready!
Details

@TomFischer TomFischer deleted the TomFischer:TimeDependentHeterogeneousParameter branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.