Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichardsMechanics: mass lumping #2590

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@endJunction
Copy link
Member

commented Aug 5, 2019

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?

endJunction added some commits Aug 5, 2019

[PL] RM; Implement mass lumping.
Both, Picard and Newton implementations are done.
@TomFischer
Copy link
Member

left a comment

Looks good.

@wenqing

wenqing approved these changes Aug 6, 2019

@@ -553,6 +560,11 @@ void RichardsMechanicsLocalAssembler<ShapeFunctionDisplacement,
dNdx_p.transpose() * rho_LR * k_rel * rho_Ki_over_mu * b * w;
}

if (_process_data.apply_mass_lumping)
{
storage_p = storage_p.colwise().sum().eval().asDiagonal();

This comment has been minimized.

Copy link
@wenqing

wenqing Aug 6, 2019

Member

In future, the name of this term is better to be unified both here and where in assemble().

@endJunction endJunction merged commit 517d0ea into ufz:master Aug 6, 2019

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190805.8 succeeded
Details

@endJunction endJunction deleted the endJunction:RMMassLumping branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.