Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RapidStn interface #2609

merged 2 commits into from Aug 16, 2019


Copy link

endJunction commented Aug 14, 2019

The removed interface is not used/tested or otherwise noted in the code.

Also reduce the scope of ThirdParty/rapidxml includes.

  1. Feature description was added to the changelog
@endJunction endJunction force-pushed the endJunction:RemoveRapidStnInterface branch from 7fb96bf to f478246 Aug 14, 2019
@bilke bilke requested a review from rinkk Aug 15, 2019
endJunction added 2 commits Aug 14, 2019
Moving the implemented function of the class reduces
the rapidxml scope to translation unit.
@endJunction endJunction force-pushed the endJunction:RemoveRapidStnInterface branch from f478246 to 2f689d3 Aug 15, 2019

This comment has been minimized.

Copy link

rinkk commented Aug 16, 2019

@endJunction endJunction merged commit a5c9255 into ufz:master Aug 16, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
deploy/netlify Deploy preview ready!
ufz.ogs #20190815.8 succeeded
@endJunction endJunction deleted the endJunction:RemoveRapidStnInterface branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.