Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split BuildInfo from BaseLib into separate libs #2625

Merged
merged 7 commits into from Aug 21, 2019
Merged

Conversation

@bilke
Copy link
Member

bilke commented Aug 21, 2019

The info from BaseLib/BuildInfo.h is now split into:

  • InfoLib/CMakeInfo.h
  • InfoLib/CompilerInfo.h (info not used)
  • InfoLib/GitInfo.h
  • InfoLib/TestInfo.h

This should help in reducing relinking when e.g. a commit was done as before this change this modified the BaseLib and everything else depends on BaseLib. Now only stuff which really uses the Git information relinks.

  1. Feature description was added to the changelog
Copy link
Member

TomFischer left a comment

👍

Copy link
Member

endJunction left a comment

Looks good!

@bilke

This comment has been minimized.

Copy link
Member Author

bilke commented Aug 21, 2019

@endJunction Shall I remove unused variables? See TestInfo.h and all variables in CompilerInfo.h.

@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Aug 21, 2019

Weren't the compiler info strings included in the --version output? Maybe I mix up with cmake info.
Drop all unused stuff, otherwise.

@bilke bilke merged commit 0678b2f into ufz:master Aug 21, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190821.3 succeeded
Details
@bilke bilke deleted the bilke:buildinfo branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.