Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MPL property: Brooks&Corey relative permeability #2656

Merged

Conversation

@Scinopode
Copy link
Contributor

Scinopode commented Sep 11, 2019

Brooks&Corey relative permeability property for the generalized material property library.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
@Scinopode Scinopode force-pushed the Scinopode:mpl_brooks_corey_relative_permeability branch 2 times, most recently from bfafbc7 to e7ad48a Sep 11, 2019
@Scinopode Scinopode force-pushed the Scinopode:mpl_brooks_corey_relative_permeability branch from e7ad48a to 27dafff Sep 12, 2019
auto const exponent =
//! \ogs_file_param{prj__media__medium__properties__property__RelPermBrooksCorey__lambda}
config.getConfigParameter<double>("lambda");
if (exponent == 0.)

This comment has been minimized.

Copy link
@TomFischer

TomFischer Sep 12, 2019

Member

The error message below is different from the check.

Suggested change
if (exponent == 0.)
if (exponent <= 0.)
const double min_relative_permeability_liquid,
const double min_relative_permeability_gas,
const double exponent)

This comment has been minimized.

Copy link
@TomFischer

TomFischer Sep 12, 2019

Member

The empty line not necessary.

ParameterLib::SpatialPosition const& pos, double const t) const
{
(void)primary_variable;
assert((primary_variable == Variable::liquid_saturation) &&

This comment has been minimized.

Copy link
@TomFischer

TomFischer Sep 12, 2019

Member

Maybe it is better to check this also in the release version?

This comment has been minimized.

Copy link
@endJunction

endJunction Sep 12, 2019

Member

not sure here, let's measure it!

This comment has been minimized.

Copy link
@TomFischer

TomFischer Sep 12, 2019

Member

Talked with @Scinopode : The primary variable isn't user input. It is 'hard' coded in the process and mistakes should be detected while the development of a new process.

const double /*_min_relative_permeability_gas*/,
const double /*exponent*/
);
/// This method assigns a pointer to the meterial object that is the owner

This comment has been minimized.

Copy link
@TomFischer

TomFischer Sep 12, 2019

Member
Suggested change
/// This method assigns a pointer to the meterial object that is the owner
/// This method assigns a pointer to the material object that is the owner
Copy link
Member

endJunction left a comment

Looks ok.

Copy link
Member

TomFischer left a comment

👍

@TomFischer TomFischer merged commit 5b00fe3 into ufz:master Sep 12, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190912.3 succeeded
Details
@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Sep 12, 2019

@Scinopode Please add this and the saturation to the Changelog!!

@Scinopode Scinopode deleted the Scinopode:mpl_brooks_corey_relative_permeability branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.