Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass dt to assemble #2673

Merged
merged 11 commits into from Sep 23, 2019
Merged

Pass dt to assemble #2673

merged 11 commits into from Sep 23, 2019

Conversation

@endJunction
Copy link
Member

endJunction commented Sep 20, 2019

Refactoring only.

The time and time increment are stored in different places like process data or coupled solutions. Another set of time and time increment is passed through the interfaces of assemble etc. functions.
To simplify (and to avoid unintentional mismatch between those) now t and dt are passed through interface to few more functions.

The bulk of the changes is to the interfaces. Some notable changes:

Changelog updated.

@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Sep 20, 2019

Compiles. Failure due to conan.

Copy link
Member

TomFischer left a comment

Looks good.

Copy link
Member

wenqing left a comment

Looks good.

endJunction added 11 commits Sep 18, 2019
With this it becomes possible to use the t/dt values
directly instead of storing them in *ProcessData
and retrieving at later point.
Updating for the changed postTimestep* interface.
Exemplary on SmallDeformationProcess, storage of dt
is no longer required and the assembly can be repeated
without dependency on the t/dt values.
Drop dt where used together with it's updates etc.
This saves passing dt to all the computeSecondaryVariable
functions. Having the dt finally removes the dt member
from the ProcessData.
Calling postTimestep is equivalent to the call of compute
secondary; see TimeLoop.cpp; those are called one after
each other.
@endJunction endJunction force-pushed the endJunction:PassDtToAssemble branch from 33905fd to 9b6ca4f Sep 23, 2019
@endJunction endJunction merged commit ab7309f into ufz:master Sep 23, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
ufz.ogs #20190923.15 failed
Details
deploy/netlify Deploy preview ready!
Details
@endJunction endJunction deleted the endJunction:PassDtToAssemble branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.