Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of source terms for lines #2685

Merged
merged 14 commits into from Oct 11, 2019
Merged

Conversation

@TomFischer
Copy link
Member

TomFischer commented Sep 27, 2019

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
@TomFischer TomFischer added the WIP 🏗 label Sep 27, 2019
@TomFischer TomFischer force-pushed the TomFischer:LineSourceTerm branch 2 times, most recently from 937bfda to 6758c05 Oct 1, 2019
@TomFischer TomFischer force-pushed the TomFischer:LineSourceTerm branch 2 times, most recently from 832e1a8 to 5943787 Oct 9, 2019
@TomFischer TomFischer added please review and removed WIP 🏗 labels Oct 10, 2019
@TomFischer TomFischer force-pushed the TomFischer:LineSourceTerm branch from ee3a63a to eb21680 Oct 10, 2019
LineSourceTermLocalAssembler(
MeshLib::Element const& element,
std::size_t const local_matrix_size,
bool is_axially_symmetric,

This comment has been minimized.

Copy link
@endJunction

endJunction Oct 10, 2019

Member
Suggested change
bool is_axially_symmetric,
bool const is_axially_symmetric,

This comment has been minimized.

Copy link
@TomFischer

TomFischer Oct 10, 2019

Author Member

Fixed.

std::vector<
IntegrationPointData<NodalRowVectorType>,
Eigen::aligned_allocator<IntegrationPointData<NodalRowVectorType>>>
_ip_data;
Comment on lines 120 to 106

This comment has been minimized.

Copy link
@endJunction

endJunction Oct 10, 2019

Member

Changing type to

Suggested change
std::vector<
IntegrationPointData<NodalRowVectorType>,
Eigen::aligned_allocator<IntegrationPointData<NodalRowVectorType>>>
_ip_data;
std::vector<NodalRowVectorType>> _ip_data;

would make the IntegrationPointData unnecessary...

This comment has been minimized.

Copy link
@TomFischer

TomFischer Oct 10, 2019

Author Member

Indeed, good point. Thanks.

@endJunction endJunction requested a review from HBShaoUFZ Oct 10, 2019
@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Oct 10, 2019

@HBShaoUFZ Could you have a look on the docu, and possibly the benchmarks too, please?

@TomFischer TomFischer force-pushed the TomFischer:LineSourceTerm branch from eb21680 to 533c63d Oct 10, 2019
Copy link
Contributor

HBShaoUFZ left a comment

Just two minor comments on the web doc.

@TomFischer TomFischer force-pushed the TomFischer:LineSourceTerm branch from 533c63d to 55b1ef8 Oct 11, 2019
@endJunction endJunction changed the title Imlementation of source terms for lines Implementation of source terms for lines Oct 11, 2019
@TomFischer TomFischer force-pushed the TomFischer:LineSourceTerm branch from 55b1ef8 to 7e0c4f7 Oct 11, 2019
@endJunction endJunction merged commit 6f5633f into ufz:master Oct 11, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20191011.2 succeeded
Details
@TomFischer TomFischer deleted the TomFischer:LineSourceTerm branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.