Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL] TES; Replace named function "vapour part. p". #2708

Merged
merged 10 commits into from Nov 5, 2019

Conversation

@endJunction
Copy link
Member

endJunction commented Nov 2, 2019

The named function is replaced with the "normal" secondary variable.
All of the named functions infrastructure is removed.

The type attribute was removed and marked deprecated (warning is issued).

<secondary_variable type="static" ... >

The "dynamic" type was nowhere used.

Review commit-wise, because some commits do the same change for many files.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added? (existing TES tests do cover this part)
  3. Any new feature or behavior change was documented? (deprecated type attribute)
endJunction added 5 commits Nov 2, 2019
The named function is replaced with the "normal" secondary
variable.
These are not used anywhere in the tests.
Update docu and make the attribute optional.
Issue a warning in case it is set.
@endJunction endJunction force-pushed the endJunction:TESReplaceGlobalNamedFunctions branch from ee0a896 to 79ca353 Nov 3, 2019
@endJunction endJunction force-pushed the endJunction:TESReplaceGlobalNamedFunctions branch from 79ca353 to bbd05d8 Nov 3, 2019
@endJunction endJunction marked this pull request as ready for review Nov 3, 2019
@wenqing
wenqing approved these changes Nov 4, 2019
Copy link
Member

wenqing left a comment

👍

@endJunction endJunction requested a review from TomFischer Nov 4, 2019
Copy link
Member

TomFischer left a comment

Very nice!

@TomFischer TomFischer merged commit dae010b into ufz:master Nov 5, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20191103.2 succeeded
Details
@endJunction endJunction deleted the endJunction:TESReplaceGlobalNamedFunctions branch Nov 5, 2019
endJunction added a commit that referenced this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.