Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Robin / Neumann boundary conditions to user needs. #2710

Merged
merged 7 commits into from Dec 3, 2019

Conversation

@TomFischer
Copy link
Member

TomFischer commented Nov 7, 2019

Add possibility to specify 'lower' dimensional Robin/Neumann boundary conditions.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Copy link
Member

endJunction left a comment

Code looks good!
Someone please check the ctests.

@TomFischer TomFischer force-pushed the TomFischer:RiverRobin branch from d2de516 to 852f43c Nov 7, 2019
@TomFischer

This comment has been minimized.

Copy link
Member Author

TomFischer commented Nov 7, 2019

Rebased and changed tolerances in ctests.

@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Nov 14, 2019

Please review.

@TomFischer TomFischer force-pushed the TomFischer:RiverRobin branch from 852f43c to f67759b Nov 14, 2019
@TomFischer

This comment has been minimized.

Copy link
Member Author

TomFischer commented Nov 14, 2019

Rebased again. Please a second reviewer!

double integral_measure = 1.0;
if (_data.integral_measure)
{
integral_measure = (*_data.integral_measure)(t, position)[0];

This comment has been minimized.

Copy link
@wenqing

wenqing Nov 14, 2019

Member
Suggested change
integral_measure = (*_data.integral_measure)(t, position)[0];
const double integral_measure = (_data.integral_measure) ? (*_data.integral_measure)(t, position)[0] : 1.0;

This comment has been minimized.

Copy link
@TomFischer

TomFischer Nov 14, 2019

Author Member

I can't declare/define the variable integral_measure only in the scope of the branch of the if condition since it is used below.

This comment has been minimized.

Copy link
@wenqing

wenqing Nov 14, 2019

Member

I see.

This comment has been minimized.

Copy link
@wenqing
ip_data.weight;
if (_data.integral_measure)
{
integral_measure = (*_data.integral_measure)(t, position)[0];

This comment has been minimized.

Copy link
@wenqing

wenqing Nov 14, 2019

Member
Suggested change
integral_measure = (*_data.integral_measure)(t, position)[0];
const double integral_measure = (_data.integral_measure) ? (*_data.integral_measure)(t, position)[0] : 1.0;

This comment has been minimized.

Copy link
@TomFischer

TomFischer Nov 14, 2019

Author Member

I think this doesn't work. See the argument in the RobinBoundaryConditionLocalAssembler case.

This comment has been minimized.

Copy link
@wenqing

wenqing Nov 14, 2019

Member

I see.

ParameterLib::SpatialPosition position;
position.setElementID(Base::_element.getID());

double integral_measure = 1.0;

This comment has been minimized.

Copy link
@wenqing

wenqing Nov 14, 2019

Member

remove it if the following suggestion (fro lines 82-84) is taken .

@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Nov 15, 2019

@TomFischer Something is consistently wrong with the parallel tests:

[2019-11-14T13:22:03.107Z] 	  2 - ogs-Parallel_2D_StaggeredScheme_ComponentTransport_TracerSimulation-mpirun (Timeout)
[2019-11-14T13:22:03.107Z] 	  3 - ogs-Parallel_2D_StaggeredScheme_ComponentTransport_TracerSimulation-mpirun-vtkdiff (Failed)
[2019-11-14T13:22:03.107Z] 	  8 - ogs-ParallelFEM_GroundWaterFlow3D_NeumannBC-mpirun (Timeout)
[2019-11-14T13:22:03.107Z] 	  9 - ogs-ParallelFEM_GroundWaterFlow3D_NeumannBC-mpirun-vtkdiff (Failed)

I restarted the parallel jenkins job yesterday with same result...

@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Nov 15, 2019

I'd think that the integral_measure should not be 1 in an axisymmetric setup. A test would be nice... Let's discuss it on Monday.

@endJunction endJunction force-pushed the ufz:master branch from 26414a0 to 564340b Nov 27, 2019
@TomFischer TomFischer force-pushed the TomFischer:RiverRobin branch 4 times, most recently from f517b47 to 96979f7 Nov 29, 2019
@TomFischer TomFischer force-pushed the TomFischer:RiverRobin branch from 96979f7 to fc21689 Dec 3, 2019
@TomFischer TomFischer merged commit 7e57984 into ufz:master Dec 3, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20191203.1 succeeded
Details
@TomFischer TomFischer deleted the TomFischer:RiverRobin branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.