Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HT] Test if all the needed material properties read from project file. #2727

Merged
merged 9 commits into from Dec 10, 2019

Conversation

@TomFischer
Copy link
Member

TomFischer commented Nov 28, 2019

Until now, OGS crashes without a useful error message when a material property isn't specified in the project file.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added? (most of the added lines are tests)
@TomFischer TomFischer force-pushed the TomFischer:HT-AddChecksForMPL branch 3 times, most recently from a6c477d to 0223245 Nov 29, 2019
@TomFischer TomFischer force-pushed the TomFischer:HT-AddChecksForMPL branch 6 times, most recently from ac5ac90 to d0caba1 Dec 2, 2019
@TomFischer TomFischer force-pushed the TomFischer:HT-AddChecksForMPL branch from d0caba1 to 3299f7a Dec 9, 2019
@TomFischer

This comment has been minimized.

Copy link
Member Author

TomFischer commented Dec 9, 2019

@bilke I haven't any idea why netlify is failing. Can you have a look, please?

WORKING_DIRECTORY ${Data_SOURCE_DIR}/Parabolic/HT/InvalidProjectFiles/)
file(GLOB HT_INVALID_PRJ_FILES ${Data_SOURCE_DIR}/Parabolic/HT/InvalidProjectFiles/*.prj)
foreach(ht_invalid_prj_file ${HT_INVALID_PRJ_FILES})
string(REPLACE ${Data_SOURCE_DIR}/Parabolic/HT/InvalidProjectFiles/HT "invalid" ht_invalid_prj_file_short ${ht_invalid_prj_file})

This comment has been minimized.

Copy link
@endJunction

endJunction Dec 9, 2019

Member

Shouldn't it be the binary dir? Polluting source dir is not nice ;)

This comment has been minimized.

Copy link
@TomFischer

TomFischer Dec 9, 2019

Author Member

Will change this tomorrow. Please don't merge.

@@ -47,6 +47,11 @@ Property const& Medium::property(PropertyType const& p) const
return *_properties[p];
}

bool Medium::isProperty(PropertyType const& p) const

This comment has been minimized.

Copy link
@endJunction

endJunction Dec 9, 2019

Member

It's maybe more the question has property, isn't it?

This comment has been minimized.

Copy link
@TomFischer

TomFischer Dec 9, 2019

Author Member

Yes, maybe hasProperty sounds more appropriate. Will change this.

@TomFischer TomFischer force-pushed the TomFischer:HT-AddChecksForMPL branch from 3299f7a to f425918 Dec 9, 2019
@bilke

This comment has been minimized.

Copy link
Member

bilke commented Dec 9, 2019

@bilke I haven't any idea why netlify is failing. Can you have a look, please?

Fetched in submodule path 'ThirdParty/ogs6py', but it did not contain 51afd2cec3678d66a00dd2e8436c9ba1d3335e3b. Direct fetching of that commit failed.
@TomFischer TomFischer merged commit f9530c2 into ufz:master Dec 10, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20191210.7 succeeded
Details
@TomFischer TomFischer deleted the TomFischer:HT-AddChecksForMPL branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.