Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richards mechanics orthotropic permeability power law #2813

Conversation

@endJunction
Copy link
Member

endJunction commented Feb 19, 2020

MPL: Passes local coordinate system to properties, s.t. these can be anisotropic
MPL: Implement orthotropic permeability power law. Tested with 90 degree rotated system.
The new permeability model is used in RichardsMechanics process.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
@endJunction endJunction marked this pull request as ready for review Feb 20, 2020
@endJunction endJunction force-pushed the endJunction:RichardsMechanicsOrthotropicPermeabilityPowerLaw branch 3 times, most recently from 8749e18 to 280014a Feb 20, 2020
if (std::holds_alternative<Phase*>(scale_pointer))
{
_phase = std::get<Phase*>(scale_pointer);
// TODO (naumov) Test phase is solid phase.

This comment has been minimized.

Copy link
@TomFischer

TomFischer Feb 21, 2020

Member

Are there any reason why this isn't done in this PR?

This comment has been minimized.

Copy link
@endJunction

endJunction Feb 21, 2020

Author Member

It was simpler, then I thought...

Copy link
Member

TomFischer left a comment

Looks good. When

  • Discussion about TODO
  • Tests are green
    then
@endJunction endJunction force-pushed the endJunction:RichardsMechanicsOrthotropicPermeabilityPowerLaw branch from 280014a to c330f8f Feb 21, 2020
@endJunction endJunction force-pushed the endJunction:RichardsMechanicsOrthotropicPermeabilityPowerLaw branch from c330f8f to 13d6037 Feb 21, 2020
Copy link
Member

wenqing left a comment

Looks good!

if (exponents.size() != 3 && exponents.size() != 2)
{
OGS_FATAL(
"The number of exponents must be two or three, but %d were given.",

This comment has been minimized.

Copy link
@wenqing

wenqing Feb 21, 2020

Member

were given --> was given

This comment has been minimized.

Copy link
@endJunction

endJunction Feb 21, 2020

Author Member

nope, its plural...

if (intrinsic_permeabilities.size() != exponents.size())
{
OGS_FATAL(
"The number of intrinsic permeabilities and exponents must be "

This comment has been minimized.

Copy link
@wenqing

wenqing Feb 21, 2020

Member
Suggested change
"The number of intrinsic permeabilities and exponents must be "
"The number of intrinsic permeabilities and the number of exponents must be "

This comment has been minimized.

Copy link
@endJunction

endJunction Feb 21, 2020

Author Member

I'd like to keep the short form.

@TomFischer TomFischer merged commit 8d979f1 into ufz:master Feb 21, 2020
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20200221.4 succeeded
Details
@TomFischer TomFischer deleted the endJunction:RichardsMechanicsOrthotropicPermeabilityPowerLaw branch Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.