Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPL in GroundwaterFlow process #2820

Merged
merged 9 commits into from Mar 4, 2020
Merged

MPL in GroundwaterFlow process #2820

merged 9 commits into from Mar 4, 2020

Conversation

@TomFischer
Copy link
Member

TomFischer commented Feb 26, 2020

Use MPL data structures in GroundwaterFlow process.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added? - Existing test are adapted.
  3. Any new feature or behavior change was documented? - There isn't any new feature.
  4. Script for automatic prj file conversion.
@TomFischer TomFischer force-pushed the TomFischer:GWFlowMPL branch from 952bb06 to 9a9515c Feb 27, 2020
Copy link
Member

wenqing left a comment

Looks good!

One benchmark fails.

@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Feb 27, 2020

Looks good.
Didn't see the diffusion prj file tag docu...
After the tests are fixed,

@TomFischer

This comment has been minimized.

Copy link
Member Author

TomFischer commented Feb 27, 2020

Didn't see the diffusion prj file tag docu...

In the prj file the property diffusion is specified by the name-tag. How should the content of the tag be documented? I didn't find documentation for all the other values of the enum PropertyType.

@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Feb 27, 2020

Never mind the tag docu. Was confused and thought it would be a new property/model.

@TomFischer TomFischer force-pushed the TomFischer:GWFlowMPL branch 2 times, most recently from 0ced1a2 to 16a2beb Feb 27, 2020
@TomFischer TomFischer force-pushed the TomFischer:GWFlowMPL branch from 16a2beb to e233063 Mar 4, 2020
@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Mar 4, 2020

@TomFischer

This comment has been minimized.

Copy link
Member Author

TomFischer commented Mar 4, 2020

TestQtPrjInterface.QtXmlPrjReader is still failing: https://jenkins.opengeosys.org/blue/organizations/jenkins/ufz%2Fogs/detail/PR-2820/8/pipeline/62

I' m already in discussion with @rinkk to fix the issue.

@TomFischer TomFischer force-pushed the TomFischer:GWFlowMPL branch from e233063 to 88a1761 Mar 4, 2020
@endJunction endJunction merged commit 8fda9af into ufz:master Mar 4, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-merge The build of this commit was aborted
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20200304.11 succeeded
Details
@endJunction endJunction deleted the TomFischer:GWFlowMPL branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.