Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPL] User-provided limits for porosity. #2829

Merged
merged 1 commit into from Mar 2, 2020

Conversation

@endJunction
Copy link
Member

endJunction commented Feb 29, 2020

Currently the limits are hard coded to be 0 and 1.
In some cases these values could be higher and lower,
respectively.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added? Existing one is updated.
  3. Any new feature or behavior change was documented?
Currently the limits are hard coded to be 0 and 1.
In some cases these values could be higher and lower,
respectively.
@endJunction endJunction force-pushed the endJunction:MplPorosityMinMaxLimits branch from d5b01eb to f975852 Mar 1, 2020
@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Mar 1, 2020

OK, now the failing builds are related to conan problems, not this PR's changes.

Copy link
Member

TomFischer left a comment

When tests are green:

@TomFischer TomFischer merged commit 408b28d into ufz:master Mar 2, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20200301.11 succeeded
Details
@TomFischer TomFischer deleted the endJunction:MplPorosityMinMaxLimits branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.