add GMRES restart option #2910
Merged
add GMRES restart option #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add gmres restart test1 set gmres restart test2 add restart option for all Preconditioners (final)
endJunction
reviewed
Apr 20, 2020
endJunction
reviewed
Apr 20, 2020
endJunction
approved these changes
Apr 20, 2020
TomFischer
reviewed
Apr 21, 2020
TomFischer
approved these changes
Apr 26, 2020
TomFischer
approved these changes
Apr 26, 2020
endJunction
reviewed
Apr 27, 2020
| } | ||
|
|
||
| template <> | ||
| void EigenIterativeLinearSolver<Eigen::GMRES<EigenMatrix::RawMatrixType, Eigen::IncompleteLUT<double>>>::setRestart(int const restart) |
There was a problem hiding this comment.
@joergbuchwald clang-format. Use pre-commit checks.
|
@joergbuchwald Small testcase using the option, something from SteadyStateDiffusion, for example, would be good. |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add restart option for the GMRES solver (Eigen-unsupported).
It sets the number of iterations before a restart is conducted. It can improve the convergence behavior. However, increasing the value comes with a tradeoff in time and memory. First tests suggest that the default value (30) is already quite optimal in most cases.