Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate all the hooks with TypeScript versions #91

Closed
bozheville opened this issue Aug 11, 2020 · 12 comments
Closed

Duplicate all the hooks with TypeScript versions #91

bozheville opened this issue Aug 11, 2020 · 12 comments

Comments

@bozheville
Copy link
Contributor

bozheville commented Aug 11, 2020

Status Hook Assignee PR
free to take useFirestoreQuery -
free to take useMemoCompare -
done useAsync - #89
free to take useRequireAuth -
free to take useRouter -
free to take useAuth -
free to take useEventListener -
free to take useWhyDidYouUpdate -
done useDarkMode - #92
done useMedia - #92
done useLockBodyScroll - #105
done useTheme - #105
free to take useSpring -
free to take useHistory -
free to take useScript -
done useKeyPress - #104
free to take useMemo -
done useDebounce - #105
done useOnScreen - #105
done usePrevious - #101
taken useOnClickOutside @frozenghozt
free to take useAnimation -
done useWindowSize - #101
done useHover - #105
done useLocalStorage - #92
done useToggle - #105

workflow:

  1. Anyone can take a hook with free to take status
  2. Once a developer wants to convert a hook, taken status and a proper assignee appears at a hook
  3. After opening a PR, pending status appears as well as PR link in the last column
  4. When a change merged, hook's status becomes done, assignee - -, PR link remains

⚠️ NOTE: Changing statuses, assignee and PR link under a developer responsibility

@larsroettig
Copy link

@gragland useWindowSize i would like to take

@sanjmgr
Copy link

sanjmgr commented Sep 6, 2020

I would love to see the complete version of all the hooks in the typescript version.

@diogosilva95
Copy link

I can take useOnClickOutside

@sanjmgr
Copy link

sanjmgr commented Sep 19, 2020

What do you guys prefer, generic or just interface/type 👍 ?

@gragland
Copy link
Contributor

gragland commented Oct 28, 2020

What do you guys prefer, generic or just interface/type 👍 ?

@bozheville thoughts on this?

@bozheville
Copy link
Contributor Author

I would say that generic with a default type is perfect when possible.

@gragland gragland pinned this issue Nov 30, 2020
@nikasepiskveradze
Copy link
Contributor

nikasepiskveradze commented Dec 1, 2020

usePrevious and useWindowSize hooks are already done(by me) and merged . Who is responsible for updating the status?

@bozheville
Copy link
Contributor Author

@nikasepiskveradze I updated a table

@nikasepiskveradze
Copy link
Contributor

nikasepiskveradze commented Dec 18, 2020

@bozheville Could you update the table. I converted those hooks: useHover, useLockBodyScroll, useTheme, useDebounce, useOnScreen and also added new hook useToggle with Typescript version. All of them are already done and merged.

@bozheville
Copy link
Contributor Author

Thank you @nikasepiskveradze! I updated the table

@GabrielModog
Copy link

I like to pick up useAnimation

@nsdonato
Copy link
Contributor

Hi, I would love to contribute, is the table up to date? Thank you <3

@tylermcginnis tylermcginnis unpinned this issue May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants