Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle in hover-mode is not toggleable on touch devices #3782

Closed
nstaeger opened this Issue Feb 23, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@nstaeger
Copy link

nstaeger commented Feb 23, 2019

UIkit version

3.0.3

Browser

Safari/Firefox on iOS, Ipad Mini, latest versions
Firefox on Windows 10 with touch input, latest versions

Reproduction Link

Official Hover-example on https://getuikit.com/docs/toggle#modes

Steps to reproduce

Use one of the above mentioned browsers and touch input to toggle the button that is in mode hover.

What is Expected?

When using touch I would expect the toggle to trigger on a click, as touch does not have a hover state. At least this was how it worked on 3.0.0-rc.16.

What is actually happening?

Nothing.

If the by me suggested exepcted behaviour is not the desired behaviour, how do I make a toggle react to hover on non-touch and to click on toch devices?

@janschoenherr

This comment has been minimized.

Copy link
Contributor

janschoenherr commented Feb 25, 2019

Thanks, fixed with e9a07e6

@nstaeger

This comment has been minimized.

Copy link
Author

nstaeger commented Feb 25, 2019

Thanks for acting that quick! Is there already a relasedate for this fix?

@nstaeger

This comment has been minimized.

Copy link
Author

nstaeger commented Mar 5, 2019

@janschoenherr Was this tested properly? I am pretty sure it was, but it is not working for me when installing from the develop branch and I cannot find the problem on my end. So I just wanted to double check.

@janschoenherr

This comment has been minimized.

Copy link
Contributor

janschoenherr commented Mar 5, 2019

Did you build the JS after using the code from develop branch? You can also pull the latest dev release from npm. The dev releases are tagged with 'dev'

yarn upgrade uikit@dev
@nstaeger

This comment has been minimized.

Copy link
Author

nstaeger commented Mar 5, 2019

@janschoenherr The uikit@dev is definitly something, that should be mentioned in the docs. Super helpful. At the end it was indeed a mistake on my side. Not exactly sure what I missed, but using your provided dependency worked out well. Now everything works as expected. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.