New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many uim-candwin-qt5 processes running #112

Closed
tomcat14d opened this Issue Aug 23, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@tomcat14d

tomcat14d commented Aug 23, 2017

I built the latest revision (ce6b4c7).
I use KDE Plasma 5.
After boot Plasma 5, many uim-candwin-qt5 processes running.
Is this a bug ?

@dai-vdr dai-vdr added bug Qt5 labels Aug 23, 2017

@dai-vdr

This comment has been minimized.

Show comment
Hide comment
@dai-vdr

dai-vdr Aug 25, 2017

Contributor

Qt5 support still under construction but dormant...

Contributor

dai-vdr commented Aug 25, 2017

Qt5 support still under construction but dormant...

@NaofumiHonda

This comment has been minimized.

Show comment
Hide comment
@NaofumiHonda

NaofumiHonda Sep 30, 2017

Contributor

As I do not use KDE 5, I cannot say a real cause, the attached patch may fix the issue.
In Qt5, each process always creates own candidate window instance even if it is not used in future.
That's why, in qt5 base system, too many candidate window processes are observed.
The attached patch delays a creation of candidate window instance until it is really needed.
Note that, after applying the patch, you may fell a short delay at the first time of appearance of a candidate window because of initialization of the candidate window.

delay.zip

Contributor

NaofumiHonda commented Sep 30, 2017

As I do not use KDE 5, I cannot say a real cause, the attached patch may fix the issue.
In Qt5, each process always creates own candidate window instance even if it is not used in future.
That's why, in qt5 base system, too many candidate window processes are observed.
The attached patch delays a creation of candidate window instance until it is really needed.
Note that, after applying the patch, you may fell a short delay at the first time of appearance of a candidate window because of initialization of the candidate window.

delay.zip

@dai-vdr

This comment has been minimized.

Show comment
Hide comment
@dai-vdr

dai-vdr Sep 30, 2017

Contributor

Thank you for your working!

But still many uim-candwin-qt5 processes running with my non KDE 5 environment.
For example, I start IM at juffed (Qt5 editor) and Wireshark (Qt5 network analyzer),
2 processes of uim-candwin-qt5 spawned. Qt5 version is 5.9.1.

P.S. could you please send pull request instead of attatchment if possible?

Contributor

dai-vdr commented Sep 30, 2017

Thank you for your working!

But still many uim-candwin-qt5 processes running with my non KDE 5 environment.
For example, I start IM at juffed (Qt5 editor) and Wireshark (Qt5 network analyzer),
2 processes of uim-candwin-qt5 spawned. Qt5 version is 5.9.1.

P.S. could you please send pull request instead of attatchment if possible?

@tomcat14d

This comment has been minimized.

Show comment
Hide comment
@tomcat14d

tomcat14d Sep 30, 2017

To NaofumiHonda san:
Thank you for your comment and patch.

I rebuilt uim applying the patch, this issue was fixed.
Before applying the patch, about 20 processes of uim-candwin-qt5 were running after starting Plasma 5, but now it is zero. (^_^)

When I start IM at Plasma 5 application such as kate, the process of uim-candwin-qt5 start normally, and the process is also closed after exiting the application.
(Before applying the patch, the process sometimes remained.)
And I don't feel the delay of display of the candidate window at all.

distribution: PCLinuxOS
Qt5 version: 5.9.1
Plasma 5 version: 5.10.5

tomcat14d commented Sep 30, 2017

To NaofumiHonda san:
Thank you for your comment and patch.

I rebuilt uim applying the patch, this issue was fixed.
Before applying the patch, about 20 processes of uim-candwin-qt5 were running after starting Plasma 5, but now it is zero. (^_^)

When I start IM at Plasma 5 application such as kate, the process of uim-candwin-qt5 start normally, and the process is also closed after exiting the application.
(Before applying the patch, the process sometimes remained.)
And I don't feel the delay of display of the candidate window at all.

distribution: PCLinuxOS
Qt5 version: 5.9.1
Plasma 5 version: 5.10.5

@NaofumiHonda

This comment has been minimized.

Show comment
Hide comment
@NaofumiHonda

NaofumiHonda Oct 1, 2017

Contributor

Thank you for your quick responses.
The patch seems to work well as expected.

Dai San: The intention of patch is NOT to unify all the processes to the unique one,
that is, it is an expected behavior for you to see two processes,
one for the editor and one for Wireshark. after you started IM conversions with candidate windows.
The issue is that a candidate window process always starts either you did IM conversion or not.
Even a daemon process invokes the one for the candidate window, as a consequence,
you got many candidate window processes when a KDE like system becomes ready,
that is fixed by this patch.

Contributor

NaofumiHonda commented Oct 1, 2017

Thank you for your quick responses.
The patch seems to work well as expected.

Dai San: The intention of patch is NOT to unify all the processes to the unique one,
that is, it is an expected behavior for you to see two processes,
one for the editor and one for Wireshark. after you started IM conversions with candidate windows.
The issue is that a candidate window process always starts either you did IM conversion or not.
Even a daemon process invokes the one for the candidate window, as a consequence,
you got many candidate window processes when a KDE like system becomes ready,
that is fixed by this patch.

@dai-vdr

This comment has been minimized.

Show comment
Hide comment
@dai-vdr

dai-vdr Oct 1, 2017

Contributor

Thank you for your explain. I misunderstand it is same as gtk's candwin that has only one process.
I merge your patch and close this now. Thank you again.

Contributor

dai-vdr commented Oct 1, 2017

Thank you for your explain. I misunderstand it is same as gtk's candwin that has only one process.
I merge your patch and close this now. Thank you again.

@dai-vdr dai-vdr closed this Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment