New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an unexpected behavior of a candidate window after my patch. #117

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
2 participants
@NaofumiHonda
Contributor

NaofumiHonda commented Nov 3, 2017

After applying the patch which fixes the issue 112, we sometimes observe the following strange behavior of a candidate window in qt5.

  1. First invoke some qt5 program like kwrite,
  2. Then input some (preeidt) string and type the conversion key several times very quickly, and as soon as possible, cancel them by hitting ESC.
    As a result, the candidate window is cancelled before its pop-up (so you never see the candidate window).
  3. Now, once focus out to other window and then focus in to the original window,
  4. Then the candidate window appears unexpectedly.

This is due to a timing issue between "pop-up" vs "hide" operations of a candidate window,
and this request resolves the issue.

@dai-vdr dai-vdr added bug Qt5 labels Nov 3, 2017

@dai-vdr dai-vdr merged commit e8e41fd into uim:master Nov 5, 2017

@dai-vdr

This comment has been minimized.

Show comment
Hide comment
@dai-vdr

dai-vdr Nov 5, 2017

Contributor

Thank you!

Contributor

dai-vdr commented Nov 5, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment