Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DESTDIR variable for qt5 inputcontext lib. #50

Merged
merged 1 commit into from Jan 19, 2016

Conversation

icy
Copy link
Contributor

@icy icy commented Nov 27, 2014

Because DESTDIR variable's null, configure script will ignore qt5 lib
path. We set it to empty variable can make it pass qt5 lib path.

Because DESTDIR variable's null, configure script will ignore qt5 lib
path. We set it to empty variable can make it pass qt5 lib path.
@dai-vdr
Copy link
Contributor

dai-vdr commented Jul 27, 2015

👍

@kou
Copy link
Member

kou commented Jul 27, 2015

Could you show how to confirm this problem is occurred?

@dai-vdr
Copy link
Contributor

dai-vdr commented Jul 27, 2015

when make all, mv libuimplatforminputcontextplugin.so into /usr/plugins.

make  -f Makefile.qmake INSTALL_ROOT= all
make[4]: Entering directory '/tmp/uim/qt5/immodule'
...
mv -f libuimplatforminputcontextplugin.so /usr/plugins/platforminputcontexts/ 

if qt5/immodule/quimplatforminputcontextplugin.pro.in does not have DESITDIR, it is not passed to qt5/immodule/Makefile:

qt5/immodule/Makefile:

...
DESTDIR = 
...
# Makefile.qmake is only exist when --enable-qt5-immodule
all clean mocclean install uninstall:
        $(MAKE) $(AM_MAKEFLAGS) -f Makefile.qmake INSTALL_ROOT=$(DESTDIR) $@
...

qt5/immodule/Makefile.qmake:

/usr/plugins/platforminputcontexts/$(TARGET):  $(OBJECTS) $(SUBLIBS) $(OBJCOMP) 

        @test -d /usr/plugins/platforminputcontexts/ || mkdir -p /usr/plugins/platforminputcontexts/
        -$(DEL_FILE) $(TARGET)
        $(LINK) $(LFLAGS) -o $(TARGET) $(OBJECTS) $(LIBS) $(OBJCOMP)
        -$(MOVE) $(TARGET) /usr/plugins/platforminputcontexts/ 

dai-vdr added a commit that referenced this pull request Jan 19, 2016
Add DESTDIR variable for qt5 inputcontext lib.
@dai-vdr dai-vdr merged commit caf65e9 into uim:master Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants