Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cannot select candidate on GTK3 application, closes #77 #84

Merged
merged 1 commit into from Jun 10, 2016

Conversation

Projects
None yet
1 participant
@dai-vdr
Copy link
Contributor

commented Jun 10, 2016

created-by: NaofumiHonda


Around the line 209 in gtk2/immodule/uim-cand-win-vertical-gtk.c, the code assumes that the conditions path_currently_selected == false and cwin->candidate_index != idx only hold for the case that a candidate is selected by a mouse click.
Surely this assumption is true for gkt2 case. However, in gtk3 case, the same conditions also hold when the candidate window becomes hidden by changing a target word, which causes a wired phenomenon.
Therefore we need to consider the latter case also and it has been done in the attached patch.

Of course, this patch respects the commitment bc40465 for SEGV.

@dai-vdr dai-vdr merged commit 108a501 into uim:master Jun 10, 2016

@dai-vdr dai-vdr deleted the dai-vdr:fix-candwin-vertical-gtk branch Jun 10, 2016

@dai-vdr dai-vdr added bug GTK3 labels Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.