New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sublime Text 3 #46

Closed
sorahn opened this Issue Mar 5, 2013 · 25 comments

Comments

Projects
None yet
@sorahn
Copy link

sorahn commented Mar 5, 2013

I don't know any of the technicals, but I can provide you with the error log.

Can't load reporter file: /Users/darylr/Library/Application Support/Sublime Text 3/Packages/JSHint/reporter.js
[Finished in 0.1s with exit code 1]
[cmd: ['jshint', '/Users/darylr/src/naiad.client.js/src/app/controllers/upsellGoldController.js', '--reporter', '/Users/darylr/Library/Application Support/Sublime Text 3/Packages/JSHint/reporter.js']]
[dir: /Users/darylr/src/naiad.client.js/src/app/controllers]
[path: /usr/bin:/bin:/usr/sbin:/sbin]
@uipoet

This comment has been minimized.

Copy link
Owner

uipoet commented Mar 6, 2013

I must confess that I haven't had the time to develop using version 3 beta yet. I will attempt a look see soon and view how the plugin API has changed.

@sorahn

This comment has been minimized.

Copy link

sorahn commented Mar 6, 2013

No worries. Take your time. I just wanted to make sure it was tracking. Also if there's anything I can do to help, let me know!

@bitbonsai

This comment has been minimized.

Copy link
Collaborator

bitbonsai commented Mar 14, 2013

I've found a workaround... tested on Windows now, when at home I'll try that on mac and add another comment...

C:>cd "%APPDATA%/Sublime Text 3/Installed Packages"
C:>cp JSHint.sublime-package "../Packages/JSHint.sublime-package.zip"

Then unzip the contents somewhere; create a folder called JSHint (inside Packages) and move the files JSHint.py and reporter.js inside it.

CTRL + J working!

@bitbonsai

This comment has been minimized.

Copy link
Collaborator

bitbonsai commented Apr 4, 2013

Hey, I just did the same for mac 10.8.3 and it's working... here are the steps:

  1. Installed wbond.net's Package manager as it's written on his page
  2. ⌘ + ⇧ + P and selected Install Package > JSHint
  3. $ cd ~/Library/Application Support/Sublime Text 3/Packages
  4. $ mkdir JSHint
  5. $ cd JSHint
  6. $ cp ../../Installed\ Packages/JSHint.sublime-package .
  7. $ unzip JSHint.sublime-package
  8. I deleted all files but JSHint.py and reporter.js
  9. That's it! ⌃ + J now is working on Sublime 3 for Mac as well (Build 3021)!

Sublime Text 3 Console

Note: If you need JSHint on HTML files (script tags inside a file) I've written JSHint-Inline

@bitbonsai bitbonsai closed this Apr 6, 2013

@stonefury

This comment has been minimized.

Copy link

stonefury commented Jun 23, 2013

Running Sublime 3 beta as of 6/21 on MacOS, and your instructions worked for JSHint Inline. Thank you and great job. JSHint is new to me, not sure if it can read included .js files, but that is something I will research offline.

Thanks again.

@kernelp4nic

This comment has been minimized.

Copy link

kernelp4nic commented Aug 7, 2013

Thanks @bitbonsai, your workaround works perfect!

@rafaelrinaldi

This comment has been minimized.

Copy link

rafaelrinaldi commented Aug 14, 2013

For some reason this plugin is not showing up on the packages list... I've started following @bitbonsai's workaround but didn't worked because there's no longer JSHint.sublime-package, only JSHint.sublime-build which is not the same thing.

@uipoet

This comment has been minimized.

Copy link
Owner

uipoet commented Aug 14, 2013

Now that Package Control supports ST3, I'll be taking a look at upgrading the necessary bits. Stay tuned.

@rafaelrinaldi

This comment has been minimized.

Copy link

rafaelrinaldi commented Aug 14, 2013

Sweet. LMK if you need some help.

@halfs13

This comment has been minimized.

Copy link

halfs13 commented Oct 2, 2013

Is the support of ST3 happening? 2 Months later and still not showing on the package control install list.

@uipoet

This comment has been minimized.

Copy link
Owner

uipoet commented Oct 3, 2013

Yes. I will be having a go at it this weekend.

@halfs13

This comment has been minimized.

Copy link

halfs13 commented Oct 3, 2013

Thanks. I'll keep an eye out.

@asakasinsky

This comment has been minimized.

Copy link

asakasinsky commented Oct 24, 2013

@bitbonsai,
Huh, keep it simple!
in error output we can see what plugin looking this path:

Packages/JSHint/reporter.js

Guess what I mean?
Right!!! We'll create this path to him:

# Going to Packages dir,
# install plugin via git
cd ~/Library/Application\ Support/Sublime\ Text\ 3/Packages
git clone https://github.com/uipoet/sublime-jshint.git JSHint

It's very simple! Nothing else to unzip! Voila!

@rafaelrinaldi

This comment has been minimized.

Copy link

rafaelrinaldi commented Oct 24, 2013

Yeah, that seem to work! Thanks @asakasinsky and mother Russia 😃

@asakasinsky

This comment has been minimized.

Copy link

asakasinsky commented Oct 26, 2013

@rafaelrinaldi , thanks for the kind words (-:

@tomfuertes

This comment has been minimized.

Copy link

tomfuertes commented Oct 30, 2013

@uipoet -- looks like the package works out of the box on ST3. Submitted the appropriate pull request to include you in the package list. Feel free to close/comment on it here:

wbond/package_control_channel#2277

tl,dr; hopefully you can "Package Install: JSHint" in ST3 once they merge this in.

@uipoet

This comment has been minimized.

Copy link
Owner

uipoet commented Oct 30, 2013

@tomfuertes Thanks for being proactive on this.

@ionutzp

This comment has been minimized.

Copy link

ionutzp commented Dec 11, 2013

i still got an error after manually creating the package and installing jshint as a node module globally fixed it

@uipoet

This comment has been minimized.

Copy link
Owner

uipoet commented Dec 11, 2013

Installing jshint as a global node module is a requirement, as stated in the readme.md

@ionutzp

This comment has been minimized.

Copy link

ionutzp commented Dec 11, 2013

@uipoet perhaps a more informative message for the error would be a good idea? i'm used to installing sublime packages straight from sublime

@uipoet

This comment has been minimized.

Copy link
Owner

uipoet commented Dec 12, 2013

@ionutzp that's a good suggestion. My python knowledge is rusty, though I assume this should be possible.

@ionutzp

This comment has been minimized.

Copy link

ionutzp commented Dec 12, 2013

@uipoet maybe just add this text to the jshint not found error message:
"DId you maybe forget to install jsHint via node?"

On Thu, Dec 12, 2013 at 1:07 AM, Jamie Hoover ⚔ notifications@github.comwrote:

@ionutzp https://github.com/ionutzp that's a good suggestion. My python
knowledge is rusty, though I assume this should be possible.


Reply to this email directly or view it on GitHubhttps://github.com//issues/46#issuecomment-30377830
.

Ionuţ Popa
twitter: @ionutzp http://twitter.com/#!/ionutzp
tumblr: http://ipopa.tumblr.com/

@uipoet

This comment has been minimized.

Copy link
Owner

uipoet commented Dec 12, 2013

I don't control that error message as it emits from node itself. It's not yet caught inside Sublime. If I can catch it, then the message makes sense.

@tomfuertes

This comment has been minimized.

Copy link

tomfuertes commented Dec 12, 2013

Could monkey patch it and paste the current error message into a stackoverflow title. Usually an instant top result. 

-Tom (via phone)

On Wed, Dec 11, 2013 at 6:42 PM, Jamie Hoover ⚔ notifications@github.com
wrote:

I don't control that error message as it emits from node itself. It's not yet caught inside Sublime. If I can catch it, then the message makes sense.

Reply to this email directly or view it on GitHub:
#46 (comment)

@ryanpcmcquen

This comment has been minimized.

Copy link

ryanpcmcquen commented Jul 11, 2017

Works great in Sublime Text 3 for me, any chance you could update the description to say 2 & 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment