Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added config parameter to make jshint respect settings in .jshintrc #38

Merged
merged 1 commit into from Jan 16, 2013

Conversation

Projects
None yet
4 participants
Contributor

xavi- commented Jan 16, 2013

No description provided.

uipoet pushed a commit that referenced this pull request Jan 16, 2013

Merge pull request #38 from xavi-/patch-1
Added config parameter to make jshint respect settings in .jshintrc

@uipoet uipoet merged commit a975fc1 into uipoet:master Jan 16, 2013

Contributor

xavi- commented Jan 16, 2013

Thank you very much. I love the plugin.

dotnil commented Jan 17, 2013

With all due respect, this change sucks, man.

By providing default --config file, my own .jshintrc settings, which is defined at each of my projects' root directory, will be overridden easily. And that's obviously not what I want.

Contributor

xavi- commented Jan 17, 2013

I don't quite understand.

As far I could tell, without the --config parameter, there was no way to override JSHint's default options (other than in-file overrides [via comments]). Does JSHint use some sort of automatic config discovery mechanism when --config is not provided?

dotnil commented Jan 17, 2013

Yes, jshint will look for .jshintrc file in the base directory of the file to be examined. If not found, it will go up to the parent folder. The search will be repeated until a .jshintrc file is found or the / directory is reached.

https://github.com/jshint/jshint#within-your-projects-directory-tree

Contributor

xavi- commented Jan 17, 2013

Oops, my bad. Then it makes sense to revert this change, though next time don't be such a dick, with all due respect. ;)

dotnil commented Jan 17, 2013

I just pointed out that you've made an annoying mistake. That's all.

Contributor

xavi- commented Jan 17, 2013

Just pointed out that you were being a dick. That's all.

dotnil commented Jan 17, 2013

@uipoet please revert this merge.

Contributor

milesmatthias commented Jan 18, 2013

I've submitted a pull request to fix this.

#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment