Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Cookies expiring after session on Safari browser (mobile & desktop) #99

Closed
bsaadat opened this issue Apr 28, 2020 · 2 comments · Fixed by #102
Closed

Bug: Cookies expiring after session on Safari browser (mobile & desktop) #99

bsaadat opened this issue Apr 28, 2020 · 2 comments · Fixed by #102
Assignees
@xenatisch
Labels
bug Something isn't working

Comments

@bsaadat
Copy link

bsaadat commented Apr 28, 2020

Summary of issue
Safari Version 13.0.4 (15608.4.9.1.3) - Failed, cookies are still expiring at the end of session, seems like a Safari only issue (Screenshot attached)

Steps to reproduce
Open dashboard in Safari
accept cookies
quit Safari
Open dashboard in Safari and will ask you to accept cookies again

Expected result
Should remember cookie settings

Actual result
Cookies expire when browser is quit

System
Safari Version 13.0.4 (15608.4.9.1.3)
@bsaadat
Copy link
Author

bsaadat commented Apr 28, 2020

image

@bsaadat
Copy link
Author

bsaadat commented Apr 28, 2020

Bug: Cookies expiring after session on Safari browser (mobile & desktop)

@bsaadat bsaadat added the bug Something isn't working label Apr 28, 2020
@xenatisch xenatisch linked a pull request Apr 28, 2020 that will close this issue
issue #99: Encode the cookie value to ensure browser compatibility #102
Merged
xenatisch added a commit that referenced this issue Apr 28, 2020
@xenatisch
Merge pull request #102 from joshuadiablito/issue #99
480f8c0 
issue #99 : Encode the cookie value to ensure browser compatibility

No conflict detected.
@xenatisch xenatisch self-assigned this Apr 28, 2020
@xenatisch xenatisch mentioned this issue Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenatisch xenatisch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@xenatisch @bsaadat