From 9806933f57e9664f4f094dbc3e17511c8daefc1b Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Sat, 8 Aug 2020 20:01:54 +0200 Subject: [PATCH] test(cli/inspector_port_collision): fail rather than hang (#6991) --- cli/tests/integration_tests.rs | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/cli/tests/integration_tests.rs b/cli/tests/integration_tests.rs index 233d53d1c0b15..29b477dc1387d 100644 --- a/cli/tests/integration_tests.rs +++ b/cli/tests/integration_tests.rs @@ -2934,10 +2934,10 @@ async fn inspector_port_collision() { .unwrap(); let stderr_1 = child1.stderr.as_mut().unwrap(); - let mut stderr_lines_1 = std::io::BufReader::new(stderr_1) + let mut stderr_1_lines = std::io::BufReader::new(stderr_1) .lines() .map(|r| r.unwrap()); - let _ = extract_ws_url_from_stderr(&mut stderr_lines_1); + let _ = extract_ws_url_from_stderr(&mut stderr_1_lines); let mut child2 = util::deno_cmd() .arg("run") @@ -2947,15 +2947,13 @@ async fn inspector_port_collision() { .spawn() .unwrap(); - use std::io::Read; - let mut stderr_str_2 = String::new(); - child2 - .stderr - .as_mut() - .unwrap() - .read_to_string(&mut stderr_str_2) - .unwrap(); - assert!(stderr_str_2.contains("Cannot start inspector server")); + let stderr_2 = child2.stderr.as_mut().unwrap(); + let stderr_2_error_message = std::io::BufReader::new(stderr_2) + .lines() + .map(|r| r.unwrap()) + .inspect(|line| assert!(!line.contains("Debugger listening"))) + .find(|line| line.contains("Cannot start inspector server")); + assert!(stderr_2_error_message.is_some()); child1.kill().unwrap(); child1.wait().unwrap();