Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 7, 2012
  1. @clang13

    [ios-sdk] Fix modal view controller toolbar sizing

    clang13 authored
    Summary:
    In landscape mode, the modal view controller toolbar was resizing improperly and the Done button was not visible.
    
    Minor tweak to legal language.
    
    Test Plan:
    - Ran Scrumptious in landscape and portrait
    - Ran PlacePickerSample in landscape and portrait
    - Ran HelloFacebookSample in landscape and portrait
    - Ran FriendPickerSample in landscape and portrait
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, ayden, gregschechte
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D541837
  2. @awzy

    Fix scroll bar in places picker

    awzy authored
    Summary: Changed the scroll bar from sorting by section when there is only one section
    
    Test Plan: Ran unit tests, PlacePicker/FriendPicker/Scrumptious samples
    
    Reviewers: jacl, clang, mmarucheck, gregschechte
    
    Reviewed By: mmarucheck
    
    CC: platform-diffs@lists, bhiller
    
    Differential Revision: https://phabricator.fb.com/D541501
    
    Task ID: 1235919
  3. Adds missing string for hebrew in FBUserSettingsControl

    Jason Clark authored
    Summary:
    This remedies a hole in the localization support (string-wise, not code-wise)
    by adding a string to the he and en strings files for "Login..."
    
    Test Plan: Ran related samples, ran unit tests
    
    Reviewers: clang, mmarucheck, ayden, gregschechte
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D541520
    
    Task ID: 1235919
  4. @clang13

    [ios-sdk] Place picker cache descriptor should use AsNeeded paging mo…

    clang13 authored
    …de rather than ImmediateViewless.
    
    Summary:
    When caching place results, we do not want to automatically follow "next" links -- we only want to cache the first
    page of results.
    
    Test Plan:
    - Ran Scrumptious, only saw one page worth of places being queried.
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D541068
Commits on Aug 6, 2012
  1. @clang13

    [ios-sdk] Fix bug where place picker cache descriptor was ignoring se…

    clang13 authored
    …archText; fix Scrumptious to call it correctly.
    
    Summary:
    Two bugs conspired to make caching inconsistent in Scrumptious. Scrumptious was passing "restaurant" as the search text
    for the place picker, but not passing it when creating a cache descriptor for background loading. The cache descriptor itself
    was also not properly using the searchText to build its URL. Fixed both of those.
    
    Also fixed Scrumptious to be less strict in the accuracy it wants, and don't fill the cache from intermediate low-accuracy
    location updates to avoid unnecessary network traffic.
    
    Test Plan:
    - Ran unit tests
    - Ran Scrumptious on device, did not notice delay when displaying places as I did without this fix
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D540969
  2. @clang13

    [ios-sdk] Fixes a few wording issues.

    clang13 authored
    Summary:
    - Capitalizes "insights" to "Insights"
    - Added a descriptive comment to HelloFacebook readme
    - Fixed wording of alert in BooleanOGSample to reflect recent UI changes
    
    Test Plan:
    - Ran BooleanOGSample, saw new wording
    
    Revert Plan:
    
    Reviewers: jacl, gregschechte
    
    Reviewed By: gregschechte
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D540768
  3. @clang13

    Add missing header docs.

    clang13 authored
    Summary: Four methods were missing header docs for a parameter. Added the docs.
    
    Test Plan:
    Ran build_distribution.sh, got no warnings from appledoc
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D540727
  4. @clang13

    [ios-sdk] Fix bug where place picker could show two selected places

    clang13 authored
    Summary:
    FBGraphObjectTableDataSource contained a bug where it would fail to deselect an item if the
    data had been reloaded since it was selected, because it was looking up objects based on their
    object address rather than their ID, and the object address would be different for the same GraphObject
    on a subsequent query.
    
    Test Plan:
    -Run PlacePickerSample
     Click in search bar
     Type "Apple"
     Select "Applebees"
     Click Cancel
     Click in search bar again
     Type "Apple"
     Select "Apple-Nuts: Apple Cider Donuts"
     Applebees is deselected -- without this fix, it stays selected
    - Ran Scrumptious, FriendPickerSample, BooleanOG
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D540720
    
    Task ID: 1327638
  5. Simplifies Scrumptious, adds support for modal dialogs

    Jason Clark authored
    Summary:
    This change simplifies the Scrumptious sample, at the same time
    highlighting the more common use case for the pickers, which is the
    model case.
    
    Test Plan: Run scrumptious on simulator, plan to run on device once built
    
    Reviewers: clang, ayden, gregschechte
    
    Reviewed By: clang
    
    Differential Revision: https://phabricator.fb.com/D540583
    
    Task ID: 1235919
  6. @clang13

    [ios-sdk] Fix issue where picker view contents would be cleared on to…

    clang13 authored
    …ken refresh.
    
    Summary:
    Handlers that cleared picker view controller data when session was closed were also incorrectly
    clearing it when tokens were refreshed, causing the control to briefly flash to a blank list.
    Data should only be cleared if the session is actually closed.
    
    Test Plan:
    - Ran Scrumptious, BooleanOG, FriendPickerSample, PlacePickerSample with token refresh timeout artificially
    set to 5 seconds -- consistently repro'd bug without this fix, no repro with this fix.
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D540547
    
    Task ID: 1321635
  7. @awzy

    Remove references to heroku images in unit tests

    awzy authored
    Summary:
    Changed the URLs in the unit tests, as well as in BooleanOG app
    I used the URLs from posting the images to a group.
    I'll change it if I get a response from the OG group.
    
    Test Plan: Ran unit tests, BooleanOG
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists, bhiller
    
    Differential Revision: https://phabricator.fb.com/D539775
    
    Task ID: 1316084
  8. Fixes KVO observer leak in FBLoginView

    Jason Clark authored
    Summary:
    FBLoginView was registering for KVO observation twice on any active
    session that became active at the time that the FBLoginView first fetched
    the session. The fix moves the current active-session wire-up before
    the global observation for active session.
    
    Test Plan: Ran tests, ran hello facebook sample
    
    Reviewers: clang, gregschechte
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D540267
    
    Task ID: 1235919
  9. @vijaye

    Updating readme with developer terms.

    vijaye authored
    Summary: Moved license info to the bottom + appended developer terms.
    
    Test Plan:
    None
    
    Reviewers: jacl, gregschechte, ekoneil
    
    Reviewed By: gregschechte
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D540334
  10. @clang13

    [ios-sdk] Fix crash in FBGraphObjectSelection

    clang13 authored
    Summary:
    A previous commit added functionality to [FBGraphObjectDataSource clearGraphObjects] that actually
    cleared the exising graph objects (as the name implies). However, this method was also being called
    whenever a new request is issued, and clearing graph objects is not what we want to do in that case,
    since during the period between the request being issued and results being returned, the user is still
    free to interact with the previously-received (or cached) data.
    
    Split clearGraphObjects into two methods and called the new method in the new-request scenario.
    
    Test Plan:
    - Ran Scrumptious
      - Selected cached friends in friend picker before and during request processing, no crash
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden, liangz
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D540026
    
    Task ID: 1318160
  11. @mingflifb

    Rename JustLoginSample to SessionLoginSample

    mingflifb authored
    Summary: Rename the JustLoginSample to SessionLoginSample.
    
    Test Plan: Built and ran the sample on the iOS simulator, verified that the functionality still works.
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    CC: dye
    
    Differential Revision: https://phabricator.fb.com/D538717
    
    Task ID: 1281869
Commits on Aug 4, 2012
  1. Add facebook settings tab to BooleanOGSample app.

    Liangxiao Zhu authored
    Summary:
    1. Adding a facebook settings tab that using FBUserSettingsViewController
    2. Removing the implicit login in and leverage the cache-only static open method on startup
    
    Test Plan:
    1. Launch the app in both iPad and iPhone emulators and make sure the app has Facebook Settings tab.
    2. Login and logout on the tab, evaluate other tab behaviors
    3. Keep the app logged out and relaunch app
    4. Logged in, exit, and relaunch app
    
    Reviewers: jacl, clang, gregschechte
    
    Reviewed By: clang
    
    CC: jwilson, clang, msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D538468
    
    Task ID: 1301048
  2. Fix issue in FriendPickerViewController that does not refresh when us…

    Liangxiao Zhu authored
    …er logout
    
    Summary:
    1. GraphObjectTableDataSource should clear out the objects that bound to tableview during clearGraphObject method.
    2. FriendPickerViewController does not refresh the table view during cleardata, the fix is to let the tableview to refresh after datasource change.
    
    Test Plan: Run the BooleanOGSample app that hosts the FriendPickerViewController using login and logout to make the list fresh
    
    Reviewers: clang, jacl
    
    Reviewed By: clang
    
    CC: jwilson, msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D539744
Commits on Aug 3, 2012
  1. Fixes regression in FBLoginView

    Jason Clark authored
    Summary:
    Overuse of the new FBSession static methods introduced an unexpected
    recursion in FBLoginView. Reverting to previous implementation.
    
    Test Plan: Ran HelloFacebook
    
    Reviewers: clang, gregschechte
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D539405
    
    Task ID: 1235919
  2. @clang13

    [ios-sdk] Fix bug in paging laoder.

    clang13 authored
    Summary:
    FBGraphObjectPagingLoader had a race condition where the data source has graph objects but
    the table has not yet been refreshed. It was trying to reference a row that didn't exist. Fixed
    it to do nothing in the case where the table does not contain rows.
    
    Fixed Scrumptious resource bundle reference.
    
    Test Plan:
    - Ran PlacePickerSample, typed "fairm" quickly in text box, did not see crash, whereas it crashed previously
    - Ran Scrumptious
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D539281
  3. Improves developer model for error handling in FBRequestConnection

    Jason Clark authored
    Summary:
    This changes requires a rational; here goes. The fix is that now the userInfo of the
    error object works the same whether or not the request is a batch. This significantly
    improves understandability, as well as makes it more feasible to write apps that dynamically
    choose to batch or not. That's the good news. There are actually two reasons to make this
    change now:
    1) The previously mentioned improvment to the developer model
    2) Changing this aspect of the developer model later would be a particularly painful
    class of breaking change, that would likely introduce difficult to find/repro bugs in apps
    
    The tradeoff is that the elegant fix to make improve the developer model is also a deep
    change that would be too risky given that we are about to move these bits to production. So
    we defer that fix until we have a time-window to stablize the change, and we make a less
    elegant, but more stable fix here -- at a skin-deep point in the code.
    
    Test Plan: ran unit tests, ran impacted samples
    
    Reviewers: gregschechte, clang, mmarucheck
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D538988
    
    Task ID: 1256476
  4. Removes preview iOS6 support, for RTM

    Jason Clark authored
    Summary:
    iOS6 integration in the codebase is provisional and for preview only,
    until iOS6 ships. Because we will soon be merging the codebase to master
    for use in production, we remove the support. Preview branches will
    continue to have and update the iOS6 preview until the OS is released.
    
    Test Plan: reran unit tests, ran a few samples
    
    Reviewers: clang, gregschechte, ayden
    
    Reviewed By: gregschechte
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D538958
    
    Task ID: 1235919
Commits on Aug 2, 2012
  1. @clang13

    [ios-sdk] Move FBUserSettingsViewController resources to separate bun…

    clang13 authored
    …dle.
    
    Summary:
    Because of the size of the graphics used by FBUserSettingsViewController, we do not want all users of the SDK
    to include them by default. Moved them to a separate FBUserSettingsViewResources.bundle.
    
    Test Plan:
    - Ran Scrumptious (English and Hebrew)
    - Ran ViewControllers test app (not checked in)
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: gregschechte
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D536978
  2. Simplifies static open methods of FBSession

    Jason Clark authored
    Summary:
    This diff -
    * Renames the static open methods to be more clearly about active session
    * Returns boolean to simplify UI setup as a result of the operation
    * Adds the ability to open in such a way as to enforce no UI (usually for app launch)
    * Updates samples accordingly
    
    Test Plan: ran impacted samples, went through the entire login cycle
    
    Reviewers: clang, gregschechte, ayden, mmarucheck
    
    Reviewed By: gregschechte
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D537878
    
    Task ID: 1188746
  3. @gregschechter

    Truncate NSLog output to avoid Xcode 4.4 lockup

    gregschechter authored
    Summary:
    Xcode 4.4 locks up when printing NSLog strings that are particularly large.  Truncate to 10,000 characters - a number arrived at because it works, and larger numbers, like 15,000 characters, cause the hang.  (Friend list retrieval, for me, is like 100,000 characters.)
    
    Facebook Task: #1293646
    
    Test Plan: Ran Scrumptious before and after.
    
    Reviewers: jacl, clang, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@, caabernathy
    
    Differential Revision: https://phabricator.fb.com/D537383
    
    Task ID: 1293646
Commits on Aug 1, 2012
  1. @awzy

    Changed objects from Boolean OG and Scrumptious from heroku to sample…

    awzy authored
    … data
    
    Summary:
    Created sample data for all of the objects in Boolean OG and Scrumptious
    Changed the samples to use this sample data instead of calling the heroku URL
    
    Test Plan: Ran BooleanOG and Scrumptious
    
    Reviewers: jacl, clang
    
    Reviewed By: jacl
    
    CC: msdkexp@, bhiller, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D534058
    
    Task ID: 1258949
  2. @vijaye

    Putting back, again, the attribute code

    vijaye authored
    Summary:
    This reverts commit c89fea4.
    
    Based on new information, we're putting back the app attribution code into the SDK.
    
    Test Plan: Build + run unit tests
    
    Reviewers: jacl, mmarucheck, clang, jketchpaw
    
    Reviewed By: jketchpaw
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D536848
  3. @clang13

    [ios-sdk] Make unit test less brittle.

    clang13 authored
    Summary:
    One of the search unit tests was assuming a certain number of results would be returned, which is clearly
    brittle in the face of data/service changes. Removed that check; the test still checks that the result it is
    expecting is returned, which suffices.
    
    Test Plan:
    - Ran unit tests, got no failures
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D536602
  4. Finishes localization support with a real local (Hebrew)

    Jason Clark authored
    Summary:
    Adds Hebrew local to prove out localization support, as well as provide
    a template for apps that want to localize
    
    Test Plan: Ran relevant samples in both locals
    
    Reviewers: clang, ayden, gregschechte
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D536587
    
    Task ID: 1223567
  5. @clang13

    [ios-sdk] Pickers should update their state when the active session c…

    clang13 authored
    …hanges.
    
    Summary:
    Pickers can track the activeSession but were not disposing of their old state when the active
    session changed, meaning they might still contain data that the new session should not have access
    to. Fixed both pickers to forget about any data they had, reset their selection, and reset their paging
    loaders whenever the active session goes away. They will check in loadData whether they need to update their
    notion of session depending on whether they were tracking the activeSession or not.
    
    Test Plan:
    - Ran unit tests
    - Ran Scrumptious
       - Logged in and out and verified that selection states and displayed data reflected activeSession state
    - Ran FriendPickerSample
    - Ran PlacePickerSample
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D536058
    
    Task ID: 1217636
  6. Merge public master hot fixes

    Jason Clark authored
    Summary:
    Just a merge of the public changes into the private master repo,
    in preparation for a push to public master
    
    @merge-commit: jacl
    
    Test Plan: Ran Hackbook and Scrumtious
    
    Reviewers: gregschechte, mmarucheck, clang
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D534966
    
    Task ID: 1235919
  7. @clang13

    [ios-sdk] Change FBLoginView and FBUserSettingsViewController to use …

    clang13 authored
    …new UX elements
    
    Summary:
    FBLoginView now consists of a single button containing a Facebook icon and "Log In"/"Log Out" text.
    
    FBUserSettingsViewController now has prettier UI. It supports all orientations on iPad but only portrait on iPhone
    because our layout is too tall to fit in landscape on a phone without some sort of smart layout approach.
    
    Test Plan:
    - Ran HelloFacebook to see FBLoginView
    - Ran (not checked in) ViewControllers test app to test FBUserSettingsViewController
    - Ran Scrumptious
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D535938
    
    Task ID: 1188684
Commits on Jul 31, 2012
  1. @awzy

    Add social context to the places picker

    awzy authored
    Summary: Added the category and "# were here" as detail text to the places picker
    
    Test Plan: Ran unit tests, places picker sample
    
    Reviewers: jacl, clang, gregschechte
    
    Reviewed By: jacl
    
    CC: platform-diffs@lists, bhiller, msdkexp@, gregschechte
    
    Differential Revision: https://phabricator.fb.com/D529501
    
    Task ID: 1118327
  2. @awzy

    Change package name to com.facebook.sdk

    awzy authored
    Summary:
    Renamed package name from com.facebook.FBiOSSDK to com.facebook.sdk
    Also cleaned up some other instances of FBiOSSDK appearing
    
    Test Plan:
    Ran unit tests
    Ran samples
    
    Reviewers: jacl, clang
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists, bhiller
    
    Differential Revision: https://phabricator.fb.com/D532201
    
    Task ID: 1167996
  3. @vijaye

    Removing attribution id reporting code

    vijaye authored
    Summary: Based on new information, we've decided to not include attribution code with the SDK
    
    Test Plan: Build & test
    
    Reviewers: jacl, mmarucheck, clang, jketchpaw
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D534745
  4. Fixes i18n bug

    Jason Clark authored
    Summary: Had a duplicate key name, which is now fixed
    
    Test Plan: Run through samples
    
    Reviewers: clang, ayden, gregschechte
    
    Reviewed By: ayden
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D534972
    
    Task ID: 1223567
Something went wrong with that request. Please try again.