Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed imports of user modules when using Python 3 #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Hi there again.

One of the last commits broke support for Python3, as discussed here: #11
I've tried to fix it. I hope it's working for you as well.
I'm not 100% sure how the code was supposed to work before, so maybe I'm missing something.

ultrabug added a commit that referenced this pull request Jun 23, 2013

fix instancemethod detection wrt issue #11 thx to @lathan and @bloodred
…, inspired by pull request #12 by @drahier
Owner

ultrabug commented Jun 23, 2013

I took inspiration from your pull request and I hope I fixed it with commit ba3dce9 , thank you mate.

Will wait for feedback before closing here.

Sorry, it was a bit late last night.

I've tested your code and it works great, as usual :)
It' also a lot more readable than the previous version.

I should've thought of using getattr myself, damn.

@ghost ghost assigned ultrabug Jun 24, 2013

Owner

ultrabug commented Jun 24, 2013

Not so "as usual" I'd say but still, thanks a lot for stepping in and helping around mate. Closing this one since version 0.13 is out and fixes this issue.

@ultrabug ultrabug closed this Jun 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment