Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for musl aarch64 (aka ARM) Linux (musllinux_1_1_aarch64) #478

Merged
merged 2 commits into from Sep 20, 2021

Conversation

bwoodsend
Copy link
Collaborator

Addresses #476 (comment).

Changes proposed in this pull request:

  • Add musl aarch64 wheels to the build matrix.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #478 (f4d8d75) into main (1dda667) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files           6        6           
  Lines        1685     1685           
=======================================
  Hits         1499     1499           
  Misses        186      186           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dda667...f4d8d75. Read the comment docs.

@bwoodsend bwoodsend force-pushed the wheels-for-musl-aarch64 branch from 0c958ee to e8621a9 Compare Sep 20, 2021
@bwoodsend bwoodsend marked this pull request as draft Sep 20, 2021
@bwoodsend bwoodsend force-pushed the wheels-for-musl-aarch64 branch from e8621a9 to ce972b4 Compare Sep 20, 2021
@bwoodsend
Copy link
Collaborator Author

Hmm, commit number 2 (ce972b4) doesn't appear to be doing anything. I guess paths: and branches: must both be satisfied rather than one or the other must be satisfied as I'd hoped. I'll drop it then enable that workflow in a throwaway branch so we can see if it works or not.

@bwoodsend
Copy link
Collaborator Author

Actually could we add workflow_dispatch: instead for one-off triggering? It would add a trigger this workflow button we can use whenever we want to work on this file without merging it into the main branch.

@hugovk
Copy link
Member

hugovk commented Sep 20, 2021

paths needs to be under an event.

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-paths

Maybe something like this?

 on:
   push:
     branches:
       - main
+  pull_request:
+    paths:
+      - ".github/workflows/deploy-wheels-linux.yml"
+      - "scripts/build-manylinux-wheels.sh"
   release:
     types:
       - published

@bwoodsend bwoodsend force-pushed the wheels-for-musl-aarch64 branch from ce972b4 to 08d7e5b Compare Sep 20, 2021
@hugovk
Copy link
Member

hugovk commented Sep 20, 2021

Actually could we add workflow_dispatch: instead for one-off triggering? It would add a trigger this workflow button we can use whenever we want to work on this file without merging it into the main branch.

Sure, can do.

Do you think we'd need a guard so this only runs when it's on main?

      - name: Publish package to TestPyPI
        uses: pypa/gh-action-pypi-publish@master

@bwoodsend
Copy link
Collaborator Author

Do you think we'd need a guard so this only runs when it's on main?

Pull requests should lack access to the authentication secrets so I imagine that step will fail. So yes, probably.

@bwoodsend
Copy link
Collaborator Author

@bwoodsend bwoodsend force-pushed the wheels-for-musl-aarch64 branch from f4d8d75 to 01d18cd Compare Sep 20, 2021
@bwoodsend bwoodsend force-pushed the wheels-for-musl-aarch64 branch from 01d18cd to f61e082 Compare Sep 20, 2021
@bwoodsend
Copy link
Collaborator Author

The travis error just looks like an internet connection blip on their end. The url it was pulling exists and works. Safe to ignore?

@hugovk
Copy link
Member

hugovk commented Sep 20, 2021

I'll hit restart on that one, but yep, safe to ignore Travis CI in this PR, we're not touching it.

@bwoodsend bwoodsend marked this pull request as ready for review Sep 20, 2021
@bwoodsend
Copy link
Collaborator Author

Travis is looking happier now!

@hugovk hugovk added the changelog: Added For new features label Sep 20, 2021
@hugovk hugovk changed the title Build wheels for musl aarch64 (aka ARM) Linux. Build wheels for musl aarch64 (aka ARM) Linux (musllinux_1_1_aarch64) Sep 20, 2021
@hugovk hugovk merged commit 9ddb36b into ultrajson:main Sep 20, 2021
55 checks passed
@hugovk
Copy link
Member

hugovk commented Sep 20, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants