Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code that used to handle the separate int type in Python 2 #509

merged 1 commit into from Feb 20, 2022


Copy link

Python 3 does not have the PyInt vs PyLong distinction that Python 2 had. Commit ff8e64c made that replacement, but obviously the second if (PyLong_Check(obj)) branch can never be executed, thus all the code exclusively referenced by it is also dead.

Copy link

Codecov Report

Merging #509 (4bb9925) into main (fbae6a3) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
+ Coverage   88.88%   89.92%   +1.04%     
  Files           6        6              
  Lines        1709     1688      -21     
- Hits         1519     1518       -1     
+ Misses        190      170      -20     
Impacted Files Coverage Δ
lib/ultrajsonenc.c 84.22% <ø> (+2.19%) ⬆️
python/objToJSON.c 86.61% <ø> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbae6a3...4bb9925. Read the comment docs.

@hugovk hugovk added the changelog: Fixed For any bug fixes label Feb 19, 2022
@bwoodsend bwoodsend merged commit f9aa23b into ultrajson:main Feb 20, 2022
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
changelog: Fixed For any bug fixes
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants