Remove dead code that used to handle the separate int type in Python 2 #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 88.88% 89.92% +1.04%
==========================================
Files 6 6
Lines 1709 1688 -21
==========================================
- Hits 1519 1518 -1
+ Misses 190 170 -20
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 does not have the
PyIntvsPyLongdistinction that Python 2 had. Commit ff8e64c made that replacement, but obviously the secondif (PyLong_Check(obj))branch can never be executed, thus all the code exclusively referenced by it is also dead.