Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant wheel dependency from pyproject.toml #535

Merged
merged 1 commit into from May 13, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 4, 2022

The wheel dependency in pyproject.toml is not necessary, and modern setuptools documentation advises against adding it. The PEP517 backend automatically exposes the wheel dependency, and a future version of setuptools may no longer use it.

A couple of references:

Committed via https://github.com/asottile/all-repos

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #535 (1a7a5f1) into main (ebdb150) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files           6        6           
  Lines        1821     1821           
=======================================
  Hits         1671     1671           
  Misses        150      150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebdb150...1a7a5f1. Read the comment docs.

@hugovk hugovk changed the title Remove redundant wheel dependency from pyproject.toml Remove redundant wheel dependency from pyproject.toml May 4, 2022
@hugovk hugovk added the changelog: Fixed For any bug fixes label May 4, 2022
@hugovk hugovk merged commit 6bba49f into main May 13, 2022
46 checks passed
@hugovk hugovk deleted the all-repos_autofix_all-repos-sed branch May 13, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants